feature/M095M01A-6 [MAGENTO 2] Add couple logging end points #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create single source of available logging endpoint providers - Update API service to make CRUD operations on log endpoints - Generate AJAX controllers to process CRUD operations from Adminhtml - Implement js modules to load, update, create logging endpoints - Implement each of the forms for the first set of providers (Amazon S3, Google BigQuery, GCS, Honeycomb, Sumo Logic)
- Fix default values for gzip config
- Implement proper JSON encoding/decoding of log format to send to the API and to display on the browser - Implement log format default samples as Fastly.com, corrected as valid JSON
MartinPeverelli
force-pushed
the
feature/M095M01A-6
branch
from
38180c3 to
641eda9
Compare
- Refactor API class to make available last call error message - Implement error message fetch and return to log endpoint create/update - Implement frontend simple form validation for all log endpoint forms (required entries only) - Add missing default values, copied from fastly's web forms
- Unescape raw default values for formats
- Undo json encoding, send log format as raw text. - Update `Placement` values and default based on Fastly UI instaed of API.
- Remove `%0D` (carriage return) char from serialized form string
- Remove JSON encode/decode from controllers when sending/receiving endpoint data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.