Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for real time logging (create new response condition) issue #682 #683

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

dpotkoc
Copy link
Contributor

@dpotkoc dpotkoc commented Jan 4, 2024

this closes #682

@dpotkoc dpotkoc mentioned this pull request Jan 4, 2024
@vvuksan vvuksan merged commit 9b89cfb into fastly:master Jan 8, 2024
4 checks passed
@vvuksan
Copy link
Contributor

vvuksan commented Jan 8, 2024

It's part of 1.2.211

@ikhadka
Copy link

ikhadka commented Jan 9, 2024

Hello Team,

@vvuksan

One of you merchant has tested this on their side and please review their feedback: We’ve updated the extension in the staging environment, tested and confirmed that the issue is partially resolved. We’re now able to attach a logging condition to a new logging endpoint when we first create it, but when we edit it, the new condition is not showing in the condition dropdown (it’s just blank). We’ve also verified that the condition is written to the generated VCL correctly.

This solution, as it stands right now, will allow us to proceed with our work, but it would be nice to be able to make changes in the future as well.

Thanks

@dpotkoc
Copy link
Contributor Author

dpotkoc commented Jan 11, 2024

thnx @ikhadka we will check it.

@dpotkoc
Copy link
Contributor Author

dpotkoc commented Jan 12, 2024

@ikhadka new fix is added in #684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug on Fastly module UI
3 participants