Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing TLS fields to Splunk #156

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Add missing TLS fields to Splunk #156

merged 1 commit into from
Apr 22, 2020

Conversation

ezkl
Copy link
Contributor

@ezkl ezkl commented Apr 21, 2020

Add missing fields tls_hostname and tls_ca_cert to Splunk logging configuration.

@ezkl
Add missing TLS fields to splunk
bc10421 
Add missing fields tls_hostname and tls_ca_cert to Splunk.
mccurdyc
mccurdyc reviewed Apr 21, 2020
View reviewed changes
Copy link
Contributor

@mccurdyc mccurdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the line breaks in the YAML.

fastly/fixtures/splunks/create.yaml Show resolved Hide resolved
mccurdyc
mccurdyc approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@mccurdyc mccurdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

phamann
phamann approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ezkl ezkl merged commit ff058e1 into fastly:master Apr 22, 2020
@ezkl ezkl deleted the ezkl/add-missing-splunk-fields branch April 22, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mccurdyc mccurdyc mccurdyc approved these changes

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezkl @phamann @mccurdyc