Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Elasticsearch endpoint support #164

Merged
merged 2 commits into from
May 11, 2020
Merged

Add Elasticsearch endpoint support #164

merged 2 commits into from
May 11, 2020

Conversation

ezkl
Copy link
Contributor

@ezkl ezkl commented May 6, 2020

See the docs for more information on Elasticsearch logging endpoints.

@ezkl ezkl requested a review from phamann May 6, 2020 22:21
@mccurdyc
elasticsearch: adds test case for Version field validation on Lists
bf615f7 
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
mccurdyc
mccurdyc approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@mccurdyc mccurdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made one change to the tests to test Version field validation for List calls.

@mccurdyc mccurdyc merged commit 2f67266 into fastly:master May 11, 2020
@ezkl ezkl deleted the ezkl/add-elasticsearch branch May 19, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mccurdyc mccurdyc mccurdyc approved these changes

@phamann phamann Awaiting requested review from phamann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezkl @mccurdyc