Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG.md for v1.16.2 #213

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Update CHANGELOG.md for v1.16.2 #213

merged 2 commits into from
Jul 13, 2020

Conversation

phamann
Copy link
Member

@phamann phamann commented Jul 13, 2020

TL;DR

Updates the changelog for v1.16.2 which includes #212

@phamann
Copy link
Member Author

phamann commented Jul 13, 2020

Unsure whether this should be a bug fix v1.16.2 or a new feature v.1.17.0?

mccurdyc
mccurdyc approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@mccurdyc mccurdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think you could argue either, so I'm fine with either.

@phamann phamann merged commit 532737c into master Jul 13, 2020
@phamann phamann deleted the phamann/v1.16.2 branch July 13, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mccurdyc mccurdyc mccurdyc approved these changes

@thommahoney thommahoney Awaiting requested review from thommahoney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phamann @mccurdyc