Add SASL fields support for Kafka Logging Endpoint #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following fields in order to support SASL: * parse_log_keyvals * auth_method * request_max_bytes * user * password
kellymclaughlin
force-pushed
the
kelly/add-kafka-sasl-fields
branch
from
be1a588
to
0d0eeff
Compare
mccurdyc
approved these changes
Oct 22, 2020
phamann
reviewed
Oct 22, 2020
Comment on lines
+32
to
+36
| ParseLogKeyvals bool `mapstructure:"parse_log_keyvals"` | ||
| RequestMaxBytes uint `mapstructure:"request_max_bytes"` | ||
| AuthMethod string `mapstructure:"auth_method"` | ||
| User string `mapstructure:"user"` | ||
| Password string `mapstructure:"password"` |
There was a problem hiding this comment.
Minor nit, the project convention is to keep the metadata fields CreatedAt etc as the last in the struct.
There was a problem hiding this comment.
Thanks, I fixed that up.
Merged
mccurdyc
changed the title
mccurdyc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following fields in order to support SASL: