New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set and advance current page #330

Merged

Integralist merged 1 commit into fastly:main from smaeda-ks:smaeda-ks/fix-paginator

Jan 17, 2022

Contributor

smaeda-ks commented Jan 17, 2022

This is a bug fix. Right now, the Page field is not handled correctly and it always fetches the collection from the beginning.

	paginator := client.NewListServicesPaginator(
		&fastly.ListServicesInput{
			PerPage: 2,
			Page:    5,
		},
	)

This PR attempts to fix this by setting p.CurrentPage = i.Page only in the initial iteration.
cc: @Integralist


          Correctly set and advance current page

fdd8c0a

Integralist added the bug label

Integralist approved these changes

View reviewed changes

Integralist merged commit 6ff3397 into fastly:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug