fastly: fix invalid package uploading test #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested changes
Nov 15, 2022
fastly/fixtures/package/get.yaml
Outdated
| - FastlyGo/2.1.0 (+github.com/fastly/go-fastly; go1.15.4) | ||
| url: https://api.fastly.com/service/7i6HN3TK9wS159v2gPAZ8A/version/2/package | ||
| - FastlyGo/7.0.0 (+github.com/fastly/go-fastly; go1.18.3) | ||
| url: https://api.fastly.com/service/pChqKASI98hryShq2mlDf6/version/2/package |
There was a problem hiding this comment.
If you could run make fix-fixtures FASTLY_TEST_SERVICE_ID="pChqKASI98hryShq2mlDf6" and that should replace any reference to your Service ID with the go-fastly generic one.
There was a problem hiding this comment.
I was pretty sure that I executed it 🤦. Probably I messed up between different test runs. Anyway, fixed and ready to review!
It seems like the expected response from Fastly API slightly changed since it was added the test for invalid packages. Now, instead of returning package info with zeroed properties, it properly returns a specific HTTP error (bad request). This PR changes the test to be compliant with the new behaviour. Signed-off-by: Gorka Lerchundi Osa <glertxundi@gmail.com>
Integralist
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the expected response from Fastly API slightly changed since it was added the test for invalid packages. Now, instead of returning package info with zeroed properties, it properly returns a specific HTTP error (bad request).
This PR changes the test to be compliant with the new behaviour.
Signed-off-by: Gorka Lerchundi Osa glertxundi@gmail.com