Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tls-subscription): serialise warnings field #409

Merged
merged 1 commit into from
Mar 14, 2023
Merged

fix(tls-subscription): serialise warnings field #409

merged 1 commit into from
Mar 14, 2023

Conversation

Integralist
Copy link
Collaborator

Fixes: #408

We should expose warnings field, as a "passing" state doesn't always indicate a successful operation.

NOTE: I've internally raised a question related to why the API returns a 200 OK when it seems a warning (as reported in the customer issue, link above) suggests that in fact this would cause the TLS subscription operation to fail.

awilliams-fastly
awilliams-fastly approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@awilliams-fastly awilliams-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Integralist Integralist merged commit 7a36fb1 into main Mar 14, 2023
@Integralist Integralist deleted the integralist/tls-auth-warnings branch March 14, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awilliams-fastly awilliams-fastly awilliams-fastly approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lack of support for warnings in TLSAuthorizations struct
2 participants
@Integralist @awilliams-fastly