feat(service_version): Add support for environments. #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋🏻 I don't see this API behaviour documented: What does the additional path segment do with regards to service activation? |
|
The API docs are still in progress. |
kpfleming
changed the title
kpfleming
approved these changes
Aug 28, 2024
|
I believe this is ready but asked for a second opinion :-) |
Integralist
reviewed
Sep 6, 2024
…ice-versions. Add 'environments' details to service and service-version API responses.
kpfleming
force-pushed
the
simon/staging
branch
from
cd46f20
to
20d8b59
Compare
kpfleming
changed the title
|
This has been simplified to remove the 'stage' and 'unstage' wrappers. It now only adds the optional 'Environment' parameter to 'Activate'/'Deactivate', and exposes the 'Environments' details included in API responses when service/version details are obtained. |
Integralist
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also Activating and Deactivating an Service Version to and from a particular Environment.
It's possible that we don't want the StageVerson and UnstageVersion shortcuts.