POC for generating API endpoints using code generation, take 2 #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydnar
reviewed
Nov 26, 2024
kpfleming
force-pushed
the
cdtool-966-2
branch
from
8984c99 to
dae678c
Compare
…kages. To support future API endpoints being located outside of the 'fastly' package, a number of types/functions/variables used in the implementations of those endpoints (and their unit tests) need to be exposed from the 'fastly' package. In addition, the 'fastly_test.go' file must be given a different name, as files named '..._test.go' cannot expose any of their declarations outside of their package. Finally, add support for Next-Gen WAF workspace IDs along side Delivery and Compute service IDs, as future API endpoints will require them.
This PR is a second proof-of-concept for generating API endpoints using the Jennifer code-generation module. It generates endpoints for Brotli compression and NGWAF as examples. For NGWAF, it includes configuration-during-enablement of the 'workspace_id', and configuration of 'workspace_id' and 'traffic_ramp' after enablement.
Initial support for generating unit tests.
kpfleming
force-pushed
the
cdtool-966-2
branch
from
dae678c to
a0bd86f
Compare
kpfleming
force-pushed
the
cdtool-966-2
branch
from
27a5426 to
067440d
Compare
|
Closing this as I've opted for a radically different approach which does not use code generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a second proof-of-concept for generating API endpoints using the Jennifer code-generation module. It generates endpoints for Brotli compression and NGWAF as examples. For NGWAF, it includes configuration-during-enablement of the 'workspace_id', and configuration of 'workspace_id' and 'traffic_ramp' after enablement.