Adding limit query parameter origin inspector #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpfleming
reviewed
Nov 26, 2024
fastly/stats_origin_inspector.go
Outdated
| @@ -91,6 +91,8 @@ type GetOriginMetricsInput struct { | |||
| End *time.Time | |||
| // GroupBy is the dimensions to return in the query. | |||
| GroupBy []string | |||
| // Limit is the limit of returned data | |||
There was a problem hiding this comment.
Please describe the units of this; is it entries, rows, something else?
There was a problem hiding this comment.
I changed it to Limit is the limit of entries requested, I also took the initiative to change it under domain inspector too.
kpfleming
approved these changes
Nov 27, 2024
Co-authored-by: Kevin P. Fleming <kpfleming@users.noreply.github.com>
Co-authored-by: Kevin P. Fleming <kpfleming@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
limitquery parameter to the request on origin inspector endpoint.