Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add format version to all missing logging providers #97

Merged
merged 3 commits into from
Jun 7, 2019
Merged

Add format version to all missing logging providers #97

merged 3 commits into from
Jun 7, 2019

Conversation

philippschulte
Copy link
Member

This solves #94.

@philippschulte
Copy link
Member Author

@sethvargo this is technically a breaking change because the function signature for getting all BigQuery logging endpoints has changed. What needs to be done before we can merge this PR. Do we have to update the CHANGELOG.md and bump the version? What would you recommend? Thanks

@sethvargo
Copy link
Contributor

@philippschulte - let's update the CHANGELOG (0.4.3 has been running along, but might want to cross-check with commits) and tag a new version (go mod and go dep all use tags). Then we can merge this.

I don't think we need to tag a new version right after merging, but after we merge, we should update the changelog to note the breaking change and start the 0.5 series. WDYT?

@matpimenta
Copy link
Contributor

@trentrosenbaum Created a new PR (#113) instead of rebasing this one. Closing this one as duplicated

@matpimenta matpimenta closed this May 24, 2019
@philippschulte
Copy link
Member Author

@matpimenta, I reopened this PR because #113 doesn't cover the changes in this PR.

@philippschulte
refactor(bigquery): implement same structure and functionality used f…
2cb4f6d 
…or all logging endpoints

BREAKING CHANGE: #GetBigQuery was renamed to #ListBigQueries and the response is sorted.
@matpimenta
Copy link
Contributor

Apologies for the confusion @philippschulte, #109 was the one to be closed duplicated. I'll review this one

trentrosenbaum
trentrosenbaum reviewed May 29, 2019
View reviewed changes
fastly/bigquery_test.go Outdated Show resolved Hide resolved
fastly/bigquery_test.go Show resolved Hide resolved
fastly/bigquery_test.go Show resolved Hide resolved
fastly/bigquery_test.go Show resolved Hide resolved
matpimenta
matpimenta reviewed May 29, 2019
View reviewed changes
fastly/bigquery.go Show resolved Hide resolved
fastly/bigquery_test.go Outdated Show resolved Hide resolved
@philippschulte philippschulte merged commit 693f551 into fastly:master Jun 7, 2019
@philippschulte philippschulte deleted the add-format_version-to-all-missing-logging-providers branch June 7, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matpimenta matpimenta matpimenta left review comments

@sethvargo sethvargo sethvargo approved these changes

@trentrosenbaum trentrosenbaum trentrosenbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philippschulte @sethvargo @matpimenta @trentrosenbaum