provider: Use real Terraform version in UA header #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
radeksimko
force-pushed
the
f-user-agent
branch
2 times, most recently
from
e248760
to
fd88995
Compare
radeksimko
force-pushed
the
f-user-agent
branch
from
fd88995
to
b27ee0e
Compare
radeksimko
force-pushed
the
f-user-agent
branch
from
b27ee0e
to
116120b
Compare
philippschulte
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
Thanks, @radeksimko for upgrading Terraform and for fixing deprecation issues!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/terraform-providers/terraform-provider-fastly/pull/187
The existing implementation leverages Terraform's
versionpackage as Terraform currently provides the SDK for interacting with core and is therefore imported by the provider, including theversionpackage.The side effect of this is that provider reports version of vendored Terraform (i.e. plugin SDK), not the version which actually talks to the provider's gRPC server and parses the configuration.
This PR is leveraging recent changes introduced in 0.12 to fix that and report accurate version.
This also changes the header from the following
to
to align UA string with hashicorp/terraform#22272