Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding in message_type support for FTP logging endpoint #288

Merged
merged 5 commits into from
Jul 20, 2020
Merged

Adding in message_type support for FTP logging endpoint #288

merged 5 commits into from
Jul 20, 2020

Conversation

annez
Copy link
Contributor

@annez annez commented Jul 17, 2020

Relates to: fastly/go-fastly#212

@ghost ghost added the size/S label Jul 17, 2020
@ghost ghost added the dependencies label Jul 17, 2020
@ghost ghost added size/XXL and removed size/S labels Jul 17, 2020
phamann
phamann approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - other than the minor whitespace nit.

fastly/block_fastly_service_v1_logging_ftp_test.go Outdated Show resolved Hide resolved
phamann
phamann approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phamann phamann merged commit d742dd8 into fastly:master Jul 20, 2020
@phamann phamann mentioned this pull request Jul 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
dependencies size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annez @phamann