Add option to disable scaled-int datatypes in InferDataTypes #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional argument
allow_scaledint_dtypes=True
toInferDataTypes
which controls whetherSCALEDINT<x>
datatypes will be inferred. If set toFalse
, those will be inferred asFLOAT32
instead. A simple testcase is also included to verify this behaviorr.Background: PR #53 introduced scaled-integer datatypes in
InferDataTypes
, mostly for the purposes of listing quantized values as scaled-integers in inferece cost. These datatypes may cause problems for backends downstream (like FINN) since they are incomplete e.g. they do not specify what the scale factor is to obtain the integer part.