Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the GitLab CI pipeline so when PRs are submitted, they can be built, linted, and tested before being merged.
build
is to ensure the build process is defined correctly, and no errors occur during build.lint
is because if you'll have the configuration defined anyway, it might as well be enforced. (A bit frustrating when doing a PR somewhere, and the main branch violates its own linting.)test
well you had this one before so you know what's up.This avoids issues, like what the repository has now, where linting is defined but
master
doesn't pass the configured linting.npm run lint
npm run build
,npm run lint
andnpm run test
all have no issues.When running
npm run build
, it changes more than just what I modified in the source for linting because of the following commit where code was updated, but the build wasn't rebuild and committed:On your end it could be worth reviewing this.
/dist
direcory meant to be in the repo?npm run build
.This won't cover issues from GitHub unfortunately, but it will make it so these issues are more promptly handled when a PR is submitted on GitLab.
If would be best if this was reviewed and merged first, and then the other PR I submitted: