Skip to content

Hotfix progress template selector (final final fix) #1097

Closed
duckduckhero wants to merge 8 commits intomainfrom
hotfix-progress-template-selector
Closed

Hotfix progress template selector (final final fix) #1097
duckduckhero wants to merge 8 commits intomainfrom
hotfix-progress-template-selector

Conversation

@duckduckhero
Copy link
Contributor

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 7, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes update cache invalidation logic in two editor-related components. In floating-button.tsx, React Query's useQueryClient is used to refresh template and LLM connection queries at relevant UI events, and a helper function is relocated outside the component. In index.tsx, useEnhanceMutation now tracks and updates LLM connection status using fresh query data before mutation.

Changes

File(s) Change Summary
apps/desktop/src/components/editor-area/floating-button.tsx Added React Query cache invalidation for "templates" and "llm-connection" queries at multiple UI events; moved extractEmojiAndName helper outside the component; performed minor code cleanup.
apps/desktop/src/components/editor-area/index.tsx Modified useEnhanceMutation to track live LLM connection status via query invalidation and internal state; updated logic to use current connection type instead of prop; removed redundant fetch.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FloatingButton
    participant QueryClient

    User->>FloatingButton: Open template popover / Add template / Open template settings
    FloatingButton->>QueryClient: Invalidate "templates" and "llm-connection" cache
    QueryClient-->>FloatingButton: Refreshed data on next query
Loading
sequenceDiagram
    participant User
    participant useEnhanceMutation
    participant QueryClient
    participant connectorCommands

    User->>useEnhanceMutation: Trigger enhancement mutation
    useEnhanceMutation->>QueryClient: Invalidate "llm-connection" cache
    useEnhanceMutation->>connectorCommands: Fetch latest LLM connection type
    connectorCommands-->>useEnhanceMutation: Return connection type ("HyprLocal" or other)
    useEnhanceMutation->>useEnhanceMutation: Update internal state with current connection type
    useEnhanceMutation->>useEnhanceMutation: Proceed with mutation using updated state
Loading

Possibly related PRs


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5872ba and b4c3b77.

📒 Files selected for processing (2)
  • apps/desktop/src/components/editor-area/floating-button.tsx (5 hunks)
  • apps/desktop/src/components/editor-area/index.tsx (7 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@duckduckhero duckduckhero deleted the hotfix-progress-template-selector branch July 7, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant