Skip to content

Client side binary diarization#1105

Merged
yujonglee merged 3 commits intomainfrom
client-side-binary-diar
Jul 8, 2025
Merged

Client side binary diarization#1105
yujonglee merged 3 commits intomainfrom
client-side-binary-diar

Conversation

@yujonglee
Copy link
Contributor

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 8, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This set of changes introduces a new English transcript dataset (english_6) and integrates it into the data and user database layers. It also expands transcript-related utilities and commands in the Tiptap editor, refactors speaker label handling, and simplifies participant and speaker selection logic in the transcript view UI, enabling more flexible speaker range operations. Additionally, grammar definitions for parsing were simplified or restructured, and minor logging and debugging enhancements were added in other crates.

Changes

File(s) Change Summary
crates/data/src/english_6/mod.rs, crates/data/src/english_6/words.json, crates/data/src/lib.rs Added new english_6 module with a large transcript JSON file and made it publicly available in the data crate.
crates/db-user/src/init.rs Updated seed logic to use english_6 transcript data instead of english_4.
apps/desktop/src/components/right-panel/views/transcript-view.tsx Removed participant-fetching logic, refactored speaker label usage, and simplified speaker selection/range UI logic.
packages/tiptap/src/transcript/index.tsx Added exports for speaker attribute constants and the getSpeakerLabel utility.
packages/tiptap/src/transcript/utils.ts Modified getSpeakerLabel to return "You" for speaker index zero.
packages/tiptap/src/transcript/nodes.ts Renamed and refactored speaker replacement commands; added new commands for replacing by speaker index and after a given position.
packages/tiptap/src/transcript/views.tsx Enhanced createSpeakerView to support new speaker range options and refactored change handling logic.
packages/tiptap/src/transcript/extensions.ts Updated split node logic to preserve speaker node attributes when splitting on Enter key.
crates/gbnf/assets/enhance-hypr.gbnf Simplified grammar by replacing nested structured rules with a simpler think block and generic content rule.
crates/gbnf/assets/enhance-other.gbnf Restructured grammar to a more detailed multi-section format with explicit headers, bullet lines, and links.
crates/llama/src/lib.rs Added private logging setup method in Llama and debug print in sampler method.
crates/template/src/lib.rs Added debug-mode printing of rendered template output in the render function.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TranscriptView
    participant TiptapEditor
    participant DataLayer

    User->>TranscriptView: Selects new speaker or range
    TranscriptView->>TiptapEditor: onSpeakerChange(range, newSpeaker)
    alt range == "current"
        TiptapEditor->>TiptapEditor: Update node attributes (ID, label, index=null)
    else range == "all"
        TiptapEditor->>TiptapEditor: replaceAllSpeakerIndices / replaceSpeakerIdsAfter
    else range == "fromHere"
        TiptapEditor->>TiptapEditor: replaceSpeakerIndicesAfter / replaceSpeakerIdsAfter
    end
    TiptapEditor-->>TranscriptView: Update reflected in editor
Loading

Possibly related PRs

  • Transcript editor styling #873: Adds a search-and-replace UI and modifies the speaker selector to manage a full Human object, including a new speaker range selector, directly overlapping with changes to speaker selection and UI logic in transcript-view.tsx.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Clippy (1.86.0)
Updating git repository `https://github.com/RustAudio/cpal`

error: failed to load source for dependency cpal

Caused by:
Unable to update https://github.com/RustAudio/cpal?rev=51c3b43#51c3b43c

Caused by:
failed to create directory /usr/local/git/db/cpal-476cd1dd23dbc279

Caused by:
Permission denied (os error 13)


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d59bcd and c211c68.

📒 Files selected for processing (9)
  • apps/desktop/src/components/right-panel/views/transcript-view.tsx (7 hunks)
  • crates/db-user/src/init.rs (1 hunks)
  • crates/gbnf/assets/enhance-hypr.gbnf (1 hunks)
  • crates/gbnf/assets/enhance-other.gbnf (1 hunks)
  • crates/llama/src/lib.rs (3 hunks)
  • crates/template/src/lib.rs (1 hunks)
  • packages/tiptap/src/transcript/extensions.ts (2 hunks)
  • packages/tiptap/src/transcript/nodes.ts (9 hunks)
  • packages/tiptap/src/transcript/views.tsx (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yujonglee yujonglee merged commit eb6360d into main Jul 8, 2025
5 of 6 checks passed
@yujonglee yujonglee deleted the client-side-binary-diar branch July 8, 2025 02:35
@yujonglee yujonglee mentioned this pull request Jul 12, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant