Skip to content

Template after recording#1110

Closed
duckduckhero wants to merge 19 commits intomainfrom
template-after-recording
Closed

Template after recording#1110
duckduckhero wants to merge 19 commits intomainfrom
template-after-recording

Conversation

@duckduckhero
Copy link
Contributor

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 8, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes introduce a streamlined approach to template-based enhancement in the editor area by passing template IDs directly to enhancement mutations, removing prior config-switching logic. A new feature allows users to select a template when stopping a recording, storing this choice for auto-enhancement. Supporting state and internationalization updates accompany these changes.

Changes

File(s) Change Summary
apps/desktop/src/components/editor-area/floating-button.tsx Removed invalidation of the "llm-connection" query on window focus after adding a template; only "templates" is now invalidated.
apps/desktop/src/components/editor-area/index.tsx Refactored enhancement logic to pass template IDs directly; removed config restoration state and hooks; updated useEnhanceMutation and useAutoEnhance signatures and usages.
apps/desktop/src/components/editor-area/note-header/listen-button.tsx Added UI and logic for selecting an auto enhance template when stopping a recording; updated stop callback signatures and integrated template selection dropdown.
apps/desktop/src/locales/en/messages.po
apps/desktop/src/locales/ko/messages.po
Updated translation source references and line numbers; added or commented out entries for "No Template (Default)" and related messages; no changes to actual translations.
apps/docs/data/i18n.json Updated i18n statistics: entry count increased from 282 to 285 for both "ko" and "en (source)"; missing count for Korean updated accordingly.
packages/utils/src/stores/ongoing-session.ts Added autoEnhanceTemplate state and setter method to the ongoing session store for storing the selected template ID to be used for auto-enhancement.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant RecordingControls
    participant OngoingSessionStore
    participant EditorArea

    User->>RecordingControls: Click Stop (with selected template)
    RecordingControls->>OngoingSessionStore: setAutoEnhanceTemplate(templateId)
    RecordingControls->>OngoingSessionStore: stopSession()
    OngoingSessionStore-->>EditorArea: autoEnhanceTemplate is set

    Note over EditorArea: On auto-enhance trigger
    EditorArea->>EditorArea: useAutoEnhance({ templateId: autoEnhanceTemplate })
    EditorArea->>EnhanceMutation: mutate({ triggerType: "auto", templateId })
    EnhanceMutation->>EditorArea: Perform enhancement with template
    EditorArea->>OngoingSessionStore: Clear autoEnhanceTemplate
Loading

Possibly related PRs

  • fastrepl/hyprnote#1095: Modified the same query invalidation logic in floating-button.tsx, directly related to the removal of "llm-connection" invalidation in this PR.
  • fastrepl/hyprnote#1089: Added template selection UI and state management, including changes to enhancement logic in the same components affected here.
  • fastrepl/hyprnote#1098: Modified both floating-button.tsx and index.tsx regarding query invalidation and enhancement mutation handling, closely related to this PR’s changes.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f91f1dd and e24c0bd.

📒 Files selected for processing (7)
  • apps/desktop/src/components/editor-area/floating-button.tsx (0 hunks)
  • apps/desktop/src/components/editor-area/index.tsx (6 hunks)
  • apps/desktop/src/components/editor-area/note-header/listen-button.tsx (8 hunks)
  • apps/desktop/src/locales/en/messages.po (11 hunks)
  • apps/desktop/src/locales/ko/messages.po (11 hunks)
  • apps/docs/data/i18n.json (1 hunks)
  • packages/utils/src/stores/ongoing-session.ts (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@duckduckhero duckduckhero deleted the template-after-recording branch July 8, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant