Skip to content

feat(desktop): add dismissible model download toast#1164

Merged
yujonglee merged 1 commit intomainfrom
Make-ai-model-dismissible
Jul 17, 2025
Merged

feat(desktop): add dismissible model download toast#1164
yujonglee merged 1 commit intomainfrom
Make-ai-model-dismissible

Conversation

@ComputelessComputer
Copy link
Collaborator

This change adds a dismissible toast notification for model downloads in the desktop application. The toast is displayed when a model download is required, and the user can dismiss the toast to prevent it from showing again during the current session.

The key changes are:

  • Add a state variable to track whether the toast has been dismissed
  • Check the dismissed state before showing the toast
  • Add a "Dismiss" button to the toast that saves the dismissed state in session storage and dismisses the toast

This change adds a dismissible toast notification for model downloads in the desktop application. The toast is displayed when a model download is required, and the user can dismiss the toast to prevent it from showing again during the current session.

The key changes are:

- Add a state variable to track whether the toast has been dismissed
- Check the dismissed state before showing the toast
- Add a "Dismiss" button to the toast that saves the dismissed state in   session storage and dismisses the toast
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 17, 2025

📝 Walkthrough

Walkthrough

The ModelDownloadNotification component was updated to track if the user has dismissed the model download toast notification using React state and sessionStorage. A "Dismiss" button was added to the toast, and the toast will not reappear during the session after dismissal.

Changes

File(s) Change Summary
apps/desktop/src/components/toast/model-download.tsx Added dismissal tracking for the toast notification using state and sessionStorage; added "Dismiss" button; updated effect dependencies.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ModelDownloadNotification
    participant sessionStorage
    participant Toast

    User->>ModelDownloadNotification: Component mounts
    ModelDownloadNotification->>sessionStorage: Check dismissal state
    alt Not dismissed
        ModelDownloadNotification->>Toast: Show model download toast
    end

    User->>Toast: Click "Dismiss" button
    Toast->>ModelDownloadNotification: onDismiss handler
    ModelDownloadNotification->>sessionStorage: Set dismissal state
    ModelDownloadNotification->>Toast: Dismiss toast
    ModelDownloadNotification->>ModelDownloadNotification: Update isDismissed state
    ModelDownloadNotification-->>Toast: Prevent future toasts this session
Loading

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af9e500 and 1618eec.

📒 Files selected for processing (1)
  • apps/desktop/src/components/toast/model-download.tsx (4 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,ts,tsx,rs}

Instructions used from:

Sources:
⚙️ CodeRabbit Configuration File

🔇 Additional comments (7)
apps/desktop/src/components/toast/model-download.tsx (7)

2-2: LGTM: Import addition is necessary and correct.

The useState import is properly added for the new dismissal state functionality.


9-10: LGTM: Good practice using a constant for the storage key.

Using a named constant prevents magic strings and improves maintainability.


13-15: LGTM: Proper lazy initialization from sessionStorage.

The state initialization correctly reads from sessionStorage using a function for lazy initialization, which is a React best practice.


75-77: LGTM: Correct placement of dismissal check.

The early return is properly placed to respect the user's dismissal preference while maintaining the existing logic flow.


102-106: LGTM: Dismiss handler is correctly implemented.

The handler properly updates both local state and sessionStorage, then dismisses the toast immediately.


128-132: LGTM: Dismiss button is properly configured.

The dismiss button is correctly added as a secondary button with appropriate label and handler.


136-136: LGTM: Dependency array correctly updated.

Adding isDismissed to the dependency array ensures the effect responds to dismissal state changes, which is necessary for proper React hook behavior.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yujonglee yujonglee merged commit 6065e9a into main Jul 17, 2025
7 checks passed
@yujonglee yujonglee deleted the Make-ai-model-dismissible branch July 17, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants