Obsidian upgrade

[duckduckhero]

• added more front matter (attendee, tags)
• added more intelligent folder routing

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The ShareButtonInNote component was updated to allow users to select a target folder when exporting notes to Obsidian. New queries fetch Obsidian folders, session tags, and participants. Exported notes now include session metadata in their frontmatter, and the export path is determined by the selected folder.

Changes

File(s)	Change Summary
apps/desktop/src/components/toolbar/buttons/share-button.tsx	Enhanced ShareButtonInNote to support folder selection for Obsidian exports, fetch session tags/participants, update export path and metadata, and add folder selection UI.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ShareButtonInNote
    participant ObsidianAPI
    participant SessionAPI

    User->>ShareButtonInNote: Open share popover
    ShareButtonInNote->>ObsidianAPI: Fetch Obsidian config and folders
    ShareButtonInNote->>SessionAPI: Fetch session tags and participants
    ShareButtonInNote->>User: Display folder selection dropdown

    User->>ShareButtonInNote: Select folder and trigger export
    ShareButtonInNote->>ObsidianAPI: Save markdown file to selected folder
    ShareButtonInNote->>ObsidianAPI: Patch frontmatter with tags and participants
    ShareButtonInNote->>User: Provide deep link to exported note

Loading

Possibly related PRs

• Obsidian upgrade #1170: Modifies ShareButtonInNote component to add folder selection for Obsidian exports, integrate session tags and participants into frontmatter, and update related queries and UI elements.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ce7bcc and f159930.

📒 Files selected for processing (1)

• apps/desktop/src/components/toolbar/buttons/share-button.tsx (5 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

🧹 Nitpick comments (2)

apps/desktop/src/components/toolbar/buttons/share-button.tsx (2)

53-54: Remove console.log statements.

Debug logging should be removed from production code.

-    console.log("folders", folders);
-    console.log("sessionTags", sessionTags);
-

---

159-159: Remove console.log statement.

Debug logging should be removed from production code.

-      console.log("obsidian modal expanded");

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6c2c4e and 1ce7bcc.

📒 Files selected for processing (1)

• apps/desktop/src/components/toolbar/buttons/share-button.tsx (5 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{js,ts,tsx,rs}

Instructions used from:

Sources:
⚙️ CodeRabbit Configuration File

🔇 Additional comments (4)

apps/desktop/src/components/toolbar/buttons/share-button.tsx (4)

13-20: Imports look good.

All new imports are properly utilized in the code.

---

140-152: Well-implemented queries with proper caching.

Good use of React Query's caching strategy with appropriate stale time settings.

---

179-195: Clean implementation of popover state management.

Good practice to refetch configuration data when the popover opens.

---

431-453: Well-implemented folder selection UI.

Clean conditional rendering with proper fallback handling.