Skip to content

frontend changes #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duckduckhero merged 2 commits into from
Jul 27, 2025
Merged

frontend changes #1224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b60431d
frontend changes
duckduckhero Jul 27, 2025
67709f3
ran tests
duckduckhero Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions apps/desktop/src/components/welcome-modal/audio-permissions-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,24 +98,34 @@ export function AudioPermissionsView({ onContinue }: AudioPermissionsViewProps)
const micPermissionStatus = useQuery({
queryKey: ["micPermission"],
queryFn: () => listenerCommands.checkMicrophoneAccess(),
refetchInterval: 3000,
refetchInterval: 1000, // ← Faster polling
});

const systemAudioPermissionStatus = useQuery({
queryKey: ["systemAudioPermission"],
queryFn: () => listenerCommands.checkSystemAudioAccess(),
refetchInterval: 3000,
refetchInterval: 1000,
});

const micPermission = useMutation({
mutationFn: () => listenerCommands.requestMicrophoneAccess(),
onSuccess: () => micPermissionStatus.refetch(),
onSuccess: () => {
// Give TCC time to update (2-5 seconds)
setTimeout(() => {
micPermissionStatus.refetch();
}, 3000);
},
onError: console.error,
});

const capturePermission = useMutation({
mutationFn: () => listenerCommands.requestSystemAudioAccess(),
onSuccess: () => systemAudioPermissionStatus.refetch(),
onSuccess: () => {
// Give TCC time to update (2-5 seconds)
setTimeout(() => {
systemAudioPermissionStatus.refetch();
}, 3000);
},
onError: console.error,
});

Expand Down Expand Up @@ -164,6 +174,11 @@ export function AudioPermissionsView({ onContinue }: AudioPermissionsViewProps)
<Trans>Grant both permissions to continue</Trans>
</p>
)}
{micPermission.isSuccess && !micPermissionStatus.data && (
<p className="text-xs text-amber-600 text-center mt-2">
<Trans>Permission granted! Detecting changes...</Trans>
</p>
)}
</div>
);
}
20 changes: 12 additions & 8 deletions apps/desktop/src/locales/en/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ msgstr "Ask questions about past meetings"
#~ msgid "Assistant:"
#~ msgstr "Assistant:"

#: src/components/welcome-modal/audio-permissions-view.tsx:127
#: src/components/welcome-modal/audio-permissions-view.tsx:137
msgid "Audio Permissions"
msgstr "Audio Permissions"

Expand Down Expand Up @@ -550,7 +550,7 @@ msgstr "Contacts Access"
#: src/components/welcome-modal/language-selection-view.tsx:180
#: src/components/welcome-modal/download-progress-view.tsx:248
#: src/components/welcome-modal/calendar-permissions-view.tsx:153
#: src/components/welcome-modal/audio-permissions-view.tsx:159
#: src/components/welcome-modal/audio-permissions-view.tsx:169
msgid "Continue"
msgstr "Continue"

Expand Down Expand Up @@ -774,11 +774,11 @@ msgstr "Get Started"
msgid "Grant Access"
msgstr "Grant Access"

#: src/components/welcome-modal/audio-permissions-view.tsx:131
#: src/components/welcome-modal/audio-permissions-view.tsx:141
msgid "Grant access to audio so Hyprnote can transcribe your meetings"
msgstr "Grant access to audio so Hyprnote can transcribe your meetings"

#: src/components/welcome-modal/audio-permissions-view.tsx:164
#: src/components/welcome-modal/audio-permissions-view.tsx:174
msgid "Grant both permissions to continue"
msgstr "Grant both permissions to continue"

Expand Down Expand Up @@ -911,7 +911,7 @@ msgstr "Member"
msgid "Members"
msgstr "Members"

#: src/components/welcome-modal/audio-permissions-view.tsx:137
#: src/components/welcome-modal/audio-permissions-view.tsx:147
#: src/components/settings/views/sound.tsx:97
msgid "Microphone Access"
msgstr "Microphone Access"
Expand Down Expand Up @@ -1065,6 +1065,10 @@ msgstr "people"
msgid "Performance difference between languages"
msgstr "Performance difference between languages"

#: src/components/welcome-modal/audio-permissions-view.tsx:179
msgid "Permission granted! Detecting changes..."
msgstr "Permission granted! Detecting changes..."

#: src/components/editor-area/note-header/listen-button.tsx:208
#~ msgid "Play video"
#~ msgstr "Play video"
Expand Down Expand Up @@ -1110,8 +1114,8 @@ msgstr "Recent Notes"
msgid "Requesting..."
msgstr "Requesting..."

#: src/components/welcome-modal/audio-permissions-view.tsx:138
#: src/components/welcome-modal/audio-permissions-view.tsx:147
#: src/components/welcome-modal/audio-permissions-view.tsx:148
#: src/components/welcome-modal/audio-permissions-view.tsx:157
msgid "Required for meeting transcription"
msgstr "Required for meeting transcription"

Expand Down Expand Up @@ -1261,7 +1265,7 @@ msgstr "Summarize meeting"
msgid "Synchronization across multiple devices"
msgstr "Synchronization across multiple devices"

#: src/components/welcome-modal/audio-permissions-view.tsx:146
#: src/components/welcome-modal/audio-permissions-view.tsx:156
#: src/components/settings/views/sound.tsx:106
msgid "System Audio Access"
msgstr "System Audio Access"
Expand Down
20 changes: 12 additions & 8 deletions apps/desktop/src/locales/ko/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ msgstr ""
#~ msgid "Assistant:"
#~ msgstr ""

#: src/components/welcome-modal/audio-permissions-view.tsx:127
#: src/components/welcome-modal/audio-permissions-view.tsx:137
msgid "Audio Permissions"
msgstr ""

Expand Down Expand Up @@ -550,7 +550,7 @@ msgstr ""
#: src/components/welcome-modal/language-selection-view.tsx:180
#: src/components/welcome-modal/download-progress-view.tsx:248
#: src/components/welcome-modal/calendar-permissions-view.tsx:153
#: src/components/welcome-modal/audio-permissions-view.tsx:159
#: src/components/welcome-modal/audio-permissions-view.tsx:169
msgid "Continue"
msgstr ""

Expand Down Expand Up @@ -774,11 +774,11 @@ msgstr ""
msgid "Grant Access"
msgstr ""

#: src/components/welcome-modal/audio-permissions-view.tsx:131
#: src/components/welcome-modal/audio-permissions-view.tsx:141
msgid "Grant access to audio so Hyprnote can transcribe your meetings"
msgstr ""

#: src/components/welcome-modal/audio-permissions-view.tsx:164
#: src/components/welcome-modal/audio-permissions-view.tsx:174
msgid "Grant both permissions to continue"
msgstr ""

Expand Down Expand Up @@ -911,7 +911,7 @@ msgstr ""
msgid "Members"
msgstr ""

#: src/components/welcome-modal/audio-permissions-view.tsx:137
#: src/components/welcome-modal/audio-permissions-view.tsx:147
#: src/components/settings/views/sound.tsx:97
msgid "Microphone Access"
msgstr ""
Expand Down Expand Up @@ -1065,6 +1065,10 @@ msgstr ""
msgid "Performance difference between languages"
msgstr ""

#: src/components/welcome-modal/audio-permissions-view.tsx:179
msgid "Permission granted! Detecting changes..."
msgstr ""

#: src/components/editor-area/note-header/listen-button.tsx:208
#~ msgid "Play video"
#~ msgstr ""
Expand Down Expand Up @@ -1110,8 +1114,8 @@ msgstr ""
msgid "Requesting..."
msgstr ""

#: src/components/welcome-modal/audio-permissions-view.tsx:138
#: src/components/welcome-modal/audio-permissions-view.tsx:147
#: src/components/welcome-modal/audio-permissions-view.tsx:148
#: src/components/welcome-modal/audio-permissions-view.tsx:157
msgid "Required for meeting transcription"
msgstr ""

Expand Down Expand Up @@ -1261,7 +1265,7 @@ msgstr ""
msgid "Synchronization across multiple devices"
msgstr ""

#: src/components/welcome-modal/audio-permissions-view.tsx:146
#: src/components/welcome-modal/audio-permissions-view.tsx:156
#: src/components/settings/views/sound.tsx:106
msgid "System Audio Access"
msgstr ""
Expand Down
Loading