Skip to content

Contact hotfix #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duckduckhero merged 2 commits into from
Aug 1, 2025
Merged

Contact hotfix #1266

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c23d83d
fixed no name contact issue
duckduckhero Aug 1, 2025
3ad6186
ran tests
duckduckhero Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions apps/desktop/src/components/finder/views/contact-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ export function ContactView({ userId, initialPersonId, initialOrgId }: ContactVi
const { data: personSessions = [] } = useQuery({
queryKey: ["person-sessions", selectedPerson || "none"],
queryFn: async () => {
// Safety check - this should never run when selectedPerson is null
if (!selectedPerson) {
throw new Error("Query should not run when selectedPerson is null");
}
Expand Down Expand Up @@ -114,16 +113,16 @@ export function ContactView({ userId, initialPersonId, initialOrgId }: ContactVi
staleTime: 30 * 1000,
});

// Client-side filtering: filter allPeopleWithUser by organization when one is selected
const displayPeople = selectedOrganization
const isValidName = (name: string | null): boolean => {
return name !== null && name !== "" && name !== "Null";
};

const displayPeople = (selectedOrganization
? allPeopleWithUser.filter(person => person.organization_id === selectedOrganization)
: allPeopleWithUser;
: allPeopleWithUser).filter(person => isValidName(person.full_name));

const selectedPersonData = displayPeople.find(p => p.id === selectedPerson);

// Simple initialization - no complex useEffects needed
// Initial state is set directly in useState above

const handleSessionClick = (sessionId: string) => {
const path = { to: "/app/note/$id", params: { id: sessionId } } as const satisfies LinkProps;

Expand Down
Loading