Chat hotfix 0802 (model switching fix)

[duckduckhero]

Summary by cubic

Fixed an issue where switching chat models did not update the tool selection, causing errors with local LLMs.

• Bug Fixes
  • Now refreshes the LLM connection before generating a response to ensure the correct tools are used.

[coderabbitai]

📝 Walkthrough

Walkthrough

The useChatLogic hook now utilizes the React Query client to explicitly invalidate and refetch the "llm-connection" query before determining the LLM connection type in processUserMessage. This ensures the latest connection status is used when deciding whether to include the update_progress tool in the streamText call.

Changes

Cohort / File(s)	Change Summary
React Query Integration in Chat Logic apps/desktop/src/components/right-panel/hooks/useChatLogic.ts	Introduced use of useQueryClient to invalidate and refetch the "llm-connection" query before checking connection type; updated logic to use the freshly fetched type for tool selection in streamText.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chat-hotfix-0802

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/desktop/src/components/right-panel/hooks/useChatLogic.ts (1)

305-308: Consider removing the arbitrary 100ms delay.

The cache invalidation approach is correct, but the 100ms delay appears arbitrary and adds unnecessary latency to message processing. React Query's invalidateQueries is synchronous for cache invalidation, and the subsequent getLlmConnection() call should fetch fresh data without the delay.

 await queryClient.invalidateQueries({ queryKey: ["llm-connection"] });
-await new Promise(resolve => setTimeout(resolve, 100));

 const { type } = await connectorCommands.getLlmConnection();

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c0ed25 and 120e529.

📒 Files selected for processing (1)

• apps/desktop/src/components/right-panel/hooks/useChatLogic.ts (3 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{js,ts,tsx,rs}

⚙️ CodeRabbit Configuration File

**/*.{js,ts,tsx,rs}: 1. No error handling.
2. No unused imports, variables, or functions.
3. For comments, keep it minimal. It should be about "Why", not "What".

Files:

• apps/desktop/src/components/right-panel/hooks/useChatLogic.ts

🔇 Additional comments (3)

apps/desktop/src/components/right-panel/hooks/useChatLogic.ts (3)

12-12: LGTM: Clean import addition.

The useQueryClient import is correctly added and will be used for cache invalidation.

---

52-52: LGTM: Proper queryClient initialization.

Standard React Query hook usage for accessing the query client.

---

313-318: LGTM: Improved conditional logic using fresh data.

The change from using potentially stale llmConnectionQuery.data?.type to the freshly fetched type variable ensures the tool availability decision is based on current connection status. This addresses the model switching issue mentioned in the PR title.

[cubic-dev-ai]

cubic analysis

No issues found across 1 file. Review in cubic