Conversation
📝 WalkthroughWalkthroughStandardizes ListenButton’s widths and labels by removing isCompact-driven variants. The resume/meeting-ended states now use fixed w-16 width with consistent labels (“Resume” on hover, “Ended” otherwise). Updates English and Korean locale strings to match and realigns translation reference line numbers. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
apps/desktop/src/locales/en/messages.po (1)
269-275: Simplify placeholder hint to match flattened UI logicThe hint still carries redundant isCompact branches. Flatten it to reduce translator confusion and keep it aligned with the component logic.
Apply this diff in the PO comment:
-#. placeholder {0}: disabled ? "Wait..." : isHovered ? (isCompact ? "Resume" : "Resume") : (isCompact ? "Ended" : "Ended") +#. placeholder {0}: disabled ? "Wait..." : isHovered ? "Resume" : "Ended"apps/desktop/src/components/editor-area/note-header/listen-button.tsx (2)
147-154: Remove redundant isCompact ternary; hardcode width and labelNow that compact/non-compact are unified, simplify to a single class and literal label. This reduces runtime branching and improves readability.
- `${ - isCompact ? "w-16" : "w-16" - } h-9 rounded-full transition-all hover:scale-95 cursor-pointer outline-none p-0 flex items-center justify-center text-xs font-medium`, + "w-16 h-9 rounded-full transition-all hover:scale-95 cursor-pointer outline-none p-0 flex items-center justify-center text-xs font-medium",- <Trans>{isCompact ? "Resume" : "Resume"}</Trans> + <Trans>Resume</Trans>
222-234: Flatten ListenButton width and label logic; remove compact branchingThe hover and default states always use a fixed width (
w-16) and labels (“Resume” on hover, “Ended” otherwise), so the nestedisCompactternaries can be collapsed. Once the compact-specific styling and text are removed (in both the paused and ended states), theisCompactprop is no longer used and can be dropped from the component’s API and its single call site.• In
apps/desktop/src/components/editor-area/note-header/listen-button.tsx, lines 145–154 (paused state) and 222–234 (ended state):
- Replace the interpolated width classes with a single string.
- Simplify the
<Trans>ternaries to two cases.• Drop the
isCompactprop from theListenButtonsignature (line 58) and from theWhenInactiveAndMeetingEndedhelper (lines 209–211).• In
apps/desktop/src/components/editor-area/note-header/index.tsx, line 106: removeisCompact={isCompact}from the<ListenButton … />usage.Example diffs:
--- a/apps/desktop/src/components/editor-area/note-header/listen-button.tsx @@ lines 145-154 - className={cn( - `${ - isCompact ? "w-16" : "w-16" - } h-9 rounded-full transition-all hover:scale-95 cursor-pointer outline-none p-0 flex items-center justify-center text-xs font-medium`, - "bg-red-100 border-2 border-red-400 text-red-600", - )} + className={cn( + "w-16 h-9 rounded-full transition-all hover:scale-95 cursor-pointer outline-none p-0 flex items-center justify-center text-xs font-medium", + "bg-red-100 border-2 border-red-400 text-red-600", + )} @@ lines 153-154 - <Trans>{isCompact ? "Resume" : "Resume"}</Trans> + <Trans>Resume</Trans>--- a/apps/desktop/src/components/editor-area/note-header/listen-button.tsx @@ lines 222-234 - className={cn( - `${ - isCompact ? "w-16" : "w-16" - } h-9 rounded-full transition-all outline-none p-0 flex items-center justify-center text-xs font-medium`, - "bg-neutral-200 border-2 border-neutral-400 text-neutral-600", - )} + className={cn( + "w-16 h-9 rounded-full transition-all outline-none p-0 flex items-center justify-center text-xs font-medium", + "bg-neutral-200 border-2 border-neutral-400 text-neutral-600", + )} ... - <Trans> - {disabled ? "Wait..." : isHovered ? (isCompact ? "Resume" : "Resume") : (isCompact ? "Ended" : "Ended")} - </Trans> + <Trans>{disabled ? "Wait..." : isHovered ? "Resume" : "Ended"}</Trans>--- a/apps/desktop/src/components/editor-area/note-header/listen-button.tsx @@ line 58 -export default function ListenButton({ sessionId, isCompact = false }: { sessionId: string; isCompact?: boolean }) { +export default function ListenButton({ sessionId }: { sessionId: string }) {--- a/apps/desktop/src/components/editor-area/note-header/index.tsx @@ line 106 - {isInNoteMain && <ListenButton sessionId={sessionId} isCompact={isCompact} />} + {isInNoteMain && <ListenButton sessionId={sessionId} />}apps/desktop/src/locales/ko/messages.po (1)
269-275: Mirror the simplified placeholder hint in KO catalogAs with EN, remove redundant compact branches in the hint to match the flattened UI and reduce translator ambiguity.
-#. placeholder {0}: disabled ? "Wait..." : isHovered ? (isCompact ? "Resume" : "Resume") : (isCompact ? "Ended" : "Ended") +#. placeholder {0}: disabled ? "Wait..." : isHovered ? "Resume" : "Ended"
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
apps/desktop/src/components/editor-area/note-header/listen-button.tsx(3 hunks)apps/desktop/src/locales/en/messages.po(12 hunks)apps/desktop/src/locales/ko/messages.po(12 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,ts,tsx,rs}
⚙️ CodeRabbit configuration file
**/*.{js,ts,tsx,rs}: 1. No error handling.
2. No unused imports, variables, or functions.
3. For comments, keep it minimal. It should be about "Why", not "What".
Files:
apps/desktop/src/components/editor-area/note-header/listen-button.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: ci (macos, macos-latest)
- GitHub Check: ci (windows, windows-latest)
🔇 Additional comments (2)
apps/desktop/src/locales/en/messages.po (1)
443-446: LGTM: Reference realignments and label consistencyThese entries reflect reference shifts and the standardized labels (“Resume”, “Ended”, “Stop”, etc.). No msgid/msgstr regressions detected.
Also applies to: 621-624, 662-666, 679-683, 1142-1145, 1226-1229, 1322-1325, 1467-1470, 1516-1519
apps/desktop/src/locales/ko/messages.po (1)
443-446: LGTM: Reference realignments and standardized labelsEntries reflect source line shifts and label standardization. No msgid/msgstr integrity issues spotted.
Also applies to: 621-624, 662-666, 679-683, 1142-1145, 1226-1229, 1322-1325, 1467-1470, 1516-1519
1 participant
Summary by cubic
Unifies the Listen button’s size and copy for a more consistent UI. Replaces “Go” with “Resume,” aligns “Ended” across compact and default, and sets both variants to the same w-16 width.
Updates EN/KO i18n strings and message references to match the new labels.