Skip to content

Minor fixes 1002 #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duckduckhero merged 3 commits into from
Oct 2, 2025
Merged

Minor fixes 1002 #1522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1089b86
listen button shape
duckduckhero Oct 2, 2025
d7b14b0
chat generating sentence
duckduckhero Oct 2, 2025
f392f96
more minor fixes
duckduckhero Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/components/editor-area/note-header/chips/tag-chip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export function TagChip({ sessionId, hashtags = [], isVeryNarrow = false, isNarr
isVeryNarrow ? "px-1.5 py-1" : "px-2 py-1.5"
} ${hasPendingActions ? "bg-gradient-to-r from-blue-50 to-purple-50 animate-pulse shadow-sm" : ""}`}
>
<TagsIcon size={14} className="flex-shrink-0 text-neutral-500" />
<span className="text-sm font-medium text-neutral-500">#</span>
{hasPendingActions && (
<div className="absolute -top-1 -right-1 w-3 h-3 bg-red-500 rounded-full border-2 border-white animate-pulse" />
)}
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/src/components/editor-area/note-header/tab-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const TabHeader = forwardRef<TabHeaderRef, TabHeaderProps>(
const canEnhanceTranscript = hasTranscript && isSessionInactive;

// Keep the "meeting session" concept for overall tab visibility
const isMeetingSession = hasTranscript || isCurrentlyRecording || isEnhancing;
const isMeetingSession = hasTranscript || isCurrentlyRecording || isEnhancing || hasEnhancedMemo;

// BUT use floating button logic for Enhanced tab visibility
const isEnhancePending = useEnhancePendingState(sessionId);
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/src/components/right-panel/components/chat/chat-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ export function ChatInput(
}}
/>
{isGenerating && !inputValue.trim() && (
<div className="placeholder-overlay">Type @(person/note name) to add context...</div>
<div className="placeholder-overlay">Ask anything, @ to add contexts...</div>
)}
</div>

Expand Down
18 changes: 9 additions & 9 deletions packages/ui/src/components/block/listen-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,10 +349,9 @@ function MicrophoneSelector({
return (
<div className="flex-1 min-w-0">
<Popover open={isOpen} onOpenChange={handleOpenChange}>
<div className="flex -space-x-px">
<Button
variant="outline"
className="rounded-r-none flex-1 min-w-0 h-10 flex items-center justify-center gap-2 transition-all hover:border-neutral-300"
<div className="flex h-10 rounded-lg border border-input overflow-hidden bg-background">
<button
className="flex-1 min-w-0 flex items-center justify-center gap-2 transition-all hover:bg-accent focus-visible:outline-none focus-visible:bg-accent disabled:opacity-50 disabled:pointer-events-none"
disabled={disabled}
onClick={onToggleMuted}
>
Expand All @@ -369,16 +368,17 @@ function MicrophoneSelector({
<SoundIndicator value={amplitude} />
</div>
)}
</Button>
</button>

<div className="w-px bg-border" />

<PopoverTrigger asChild>
<Button
variant="outline"
className="rounded-l-none px-1.5 flex-shrink-0 h-10 transition-all hover:border-neutral-300 hover:bg-neutral-50"
<button
className="px-1.5 flex-shrink-0 flex items-center justify-center transition-all hover:bg-accent focus-visible:outline-none focus-visible:bg-accent disabled:opacity-50 disabled:pointer-events-none"
disabled={disabled}
>
<ChevronDownIcon className="w-4 h-4 text-neutral-600" />
</Button>
</button>
</PopoverTrigger>
</div>

Expand Down
Loading