Skip to content

ui changes#1570

Closed
ComputelessComputer wants to merge 3 commits intomainfrom
jj-branch-20
Closed

ui changes#1570
ComputelessComputer wants to merge 3 commits intomainfrom
jj-branch-20

Conversation

@ComputelessComputer
Copy link
Collaborator

• Implemented outer header
• Rolled back background color
• Updated editor area

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

📝 Walkthrough

Walkthrough

Refactors layout and styling across Sessions components: adjusts padding, gaps, overflow, and header composition; replaces some icon/button implementations and class management with cn/clsx; introduces minor visual tweaks in sidebar timeline and participants chip. No public API or control-flow changes.

Changes

Cohort / File(s) Summary
Sessions layout and spacing
apps/desktop2/src/components/main/body/sessions/index.tsx, .../sessions/inner-header.tsx, .../sessions/title-input.tsx
Reworked wrappers, gaps, and padding; switched to overflow-y on content; added horizontal padding to inner header and title input.
OuterHeader structure and buttons
.../sessions/outer-header/index.tsx, .../sessions/outer-header/listen.tsx, .../sessions/outer-header/recording.tsx, .../sessions/outer-header/share.tsx, .../sessions/outer-header/other.tsx
Tweaked header spacing and grouping; revamped button class composition with cn/clsx; added loading ping in Listen; updated icon for “More” and added hover/rounded styles; adjusted gaps in recording states.
Sidebar timeline visual tweak
apps/desktop2/src/components/main/sidebar/timeline.tsx
Added bg-color1 to sticky date header.
Participants chip cleanup
packages/ui/src/components/block/participants-chip.tsx
Switched Linkedin to LinkedinIcon; consolidated padding via cn with conditional px classes.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • duckduckhero

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title succinctly summarizes the main changes by naming the implementation of the outer header, updates to the editor area, and the background color revert, all of which match the changes described in the diff without extraneous detail.
Description Check ✅ Passed The pull request description lists the key changes—implementing the outer header, reverting the background color, and updating the editor area—which directly correspond to the modifications in the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jj-branch-20

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec593f5 and e5e95c7.

📒 Files selected for processing (10)
  • apps/desktop2/src/components/main/body/sessions/index.tsx (2 hunks)
  • apps/desktop2/src/components/main/body/sessions/inner-header.tsx (1 hunks)
  • apps/desktop2/src/components/main/body/sessions/outer-header/index.tsx (2 hunks)
  • apps/desktop2/src/components/main/body/sessions/outer-header/listen.tsx (1 hunks)
  • apps/desktop2/src/components/main/body/sessions/outer-header/other.tsx (1 hunks)
  • apps/desktop2/src/components/main/body/sessions/outer-header/recording.tsx (3 hunks)
  • apps/desktop2/src/components/main/body/sessions/outer-header/share.tsx (1 hunks)
  • apps/desktop2/src/components/main/body/sessions/title-input.tsx (1 hunks)
  • apps/desktop2/src/components/main/sidebar/timeline.tsx (1 hunks)
  • packages/ui/src/components/block/participants-chip.tsx (3 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
apps/desktop2/**/*.{tsx,jsx}

📄 CodeRabbit inference engine (apps/desktop2/.cursor/rules/style.mdc)

apps/desktop2/**/*.{tsx,jsx}: When there are many Tailwind classNames with conditional logic, use the cn utility imported as import { cn } from "@hypr/ui/lib/utils"
Always pass an array to cn when composing Tailwind classNames
Split cn array entries by logical grouping when composing Tailwind classNames

Files:

  • apps/desktop2/src/components/main/body/sessions/outer-header/recording.tsx
  • apps/desktop2/src/components/main/body/sessions/outer-header/share.tsx
  • apps/desktop2/src/components/main/body/sessions/inner-header.tsx
  • apps/desktop2/src/components/main/body/sessions/title-input.tsx
  • apps/desktop2/src/components/main/body/sessions/outer-header/listen.tsx
  • apps/desktop2/src/components/main/sidebar/timeline.tsx
  • apps/desktop2/src/components/main/body/sessions/outer-header/other.tsx
  • apps/desktop2/src/components/main/body/sessions/index.tsx
  • apps/desktop2/src/components/main/body/sessions/outer-header/index.tsx
**/*.{js,ts,tsx,rs}

⚙️ CodeRabbit configuration file

**/*.{js,ts,tsx,rs}: 1. Do not add any error handling. Keep the existing one.
2. No unused imports, variables, or functions.
3. For comments, keep it minimal. It should be about "Why", not "What".

Files:

  • apps/desktop2/src/components/main/body/sessions/outer-header/recording.tsx
  • apps/desktop2/src/components/main/body/sessions/outer-header/share.tsx
  • apps/desktop2/src/components/main/body/sessions/inner-header.tsx
  • apps/desktop2/src/components/main/body/sessions/title-input.tsx
  • apps/desktop2/src/components/main/body/sessions/outer-header/listen.tsx
  • packages/ui/src/components/block/participants-chip.tsx
  • apps/desktop2/src/components/main/sidebar/timeline.tsx
  • apps/desktop2/src/components/main/body/sessions/outer-header/other.tsx
  • apps/desktop2/src/components/main/body/sessions/index.tsx
  • apps/desktop2/src/components/main/body/sessions/outer-header/index.tsx
🧬 Code graph analysis (6)
apps/desktop2/src/components/main/body/sessions/outer-header/recording.tsx (1)
packages/ui/src/lib/utils.ts (1)
  • cn (4-6)
apps/desktop2/src/components/main/body/sessions/outer-header/listen.tsx (1)
apps/desktop2/src/components/main/body/sessions/outer-header/types.ts (1)
  • SessionRowProp (3-5)
packages/ui/src/components/block/participants-chip.tsx (1)
packages/ui/src/lib/utils.ts (1)
  • cn (4-6)
apps/desktop2/src/components/main/body/sessions/outer-header/other.tsx (1)
apps/desktop2/src/components/main/body/sessions/outer-header/types.ts (1)
  • SessionRowProp (3-5)
apps/desktop2/src/components/main/body/sessions/index.tsx (1)
apps/desktop2/src/components/main/body/sessions/outer-header/index.tsx (1)
  • OuterHeader (12-59)
apps/desktop2/src/components/main/body/sessions/outer-header/index.tsx (2)
apps/desktop2/src/components/main/body/sessions/outer-header/share.tsx (1)
  • ShareButton (3-9)
apps/desktop2/src/components/main/body/sessions/outer-header/other.tsx (1)
  • OthersButton (5-11)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: ci (macos, macos-14)
  • GitHub Check: ci (windows, windows-latest)
  • GitHub Check: zizmor
🔇 Additional comments (5)
apps/desktop2/src/components/main/body/sessions/outer-header/index.tsx (2)

38-38: LGTM!

The spacing reduction from gap-3 to gap-2 tightens the header button layout appropriately.


52-55: LGTM! Buttons intentionally grouped without internal gap.

ShareButton and OthersButton are now visually grouped as a single unit. The wrapper has no gap between them (making them flush), while the parent's gap-2 maintains spacing from other elements.

apps/desktop2/src/components/main/body/sessions/index.tsx (3)

62-62: LGTM! Container structure updated correctly.

The main container now includes flex-1 overflow-hidden relative gap-1 which properly constrains overflow and adds spacing between children. The combination of flex-1 and overflow-hidden on the parent with overflow-y-auto on the child (line 81) creates the correct scroll behavior.


63-68: LGTM! Cleaner structure.

Removing the wrapper div around OuterHeader simplifies the DOM structure while maintaining the same functionality.


81-81: LGTM! Improved overflow behavior and spacing.

Changing from overflow-auto to overflow-y-auto correctly prevents horizontal scrolling. The addition of pt-3 px-2 provides appropriate padding for the editor area.

@yujonglee yujonglee closed this Oct 15, 2025
@yujonglee yujonglee deleted the jj-branch-20 branch October 15, 2025 03:00
yujonglee added a commit that referenced this pull request Oct 15, 2025
@yujonglee
Copy link
Contributor

12f9665

@ComputelessComputer ComputelessComputer changed the title Implement Outer Header and Editor Area Updates (Revert BG Color) ui changes Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants