fix duplicated enhanced tab & streaming UI enhancement#1882
Conversation
include finalizing session mode - Use `templateId || undefined` instead of `templateId ?? undefined` to coerce empty-string values to undefined so template id normalization treats empty strings the same as missing values. Normalize existing template id value (`existingTemplateId || undefined`) before comparison to avoid false mismatches when stored values are empty strings. Treat "finalizing" sessionMode as a running state that short-circuits enhanced-note processing, preventing modification during finalization. ese changes fix incorrect equality checks and ensure enhanced note logic behaves correctly for empty template ids and during finalization.
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughNormalize empty Changes
Sequence Diagram(s)Feature: useEnhancedNotes — early-return during finalizing and templateId normalization sequenceDiagram
participant UI
participant useEnhancedNotes
participant Storage
UI->>useEnhancedNotes: call (sessionMode, templateId)
alt sessionMode == "finalizing"
useEnhancedNotes-->>UI: return early (no default summary)
else
useEnhancedNotes->>Storage: normalize templateId ('' -> undefined)
useEnhancedNotes->>Storage: compare existingTemplateId (normalized)
useEnhancedNotes-->>UI: proceed with create/ensure default summary if needed
end
Feature: Streaming UI rendering change (high-level) sequenceDiagram
participant Renderer
participant LayoutGroup
participant MotionWrapper
participant Streamdown
participant Status
Renderer->>LayoutGroup: render
LayoutGroup->>MotionWrapper: wrap streamed content
MotionWrapper->>Streamdown: stream content (no isAnimating prop)
alt isGenerating == true
LayoutGroup->>Status: render sticky status (motion div)
Status-->>Renderer: show generating state
else
LayoutGroup-->>Renderer: hide status
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Comment |
No description provided.