Skip to content

just renaming stuffs#1923

Merged
yujonglee merged 1 commit intomainfrom
yl-branch-81
Nov 26, 2025
Merged

just renaming stuffs#1923
yujonglee merged 1 commit intomainfrom
yl-branch-81

Conversation

@yujonglee
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit 2e41384
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/6926d887a726770008518567
😎 Deploy Preview https://deploy-preview-1923--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for hyprnote-storybook ready!

Name Link
🔨 Latest commit 2e41384
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/6926d887b574a30008b0ca41
😎 Deploy Preview https://deploy-preview-1923--hyprnote-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 26, 2025

📝 Walkthrough

Walkthrough

This PR reorganizes the listener plugin's module structure by moving session-related types from a supervisor module to a new session module within actors, updating import paths across the codebase, and removing the old supervisor module from the public API.

Changes

Cohort / File(s) Summary
Module reorganization and removal
plugins/listener/src/actors/mod.rs, plugins/listener/src/lib.rs
Introduces new session module in actors with public re-export; removes supervisor module declaration and its public re-exports of session_supervisor_name, SessionContext, and SessionParams.
Import path updates
plugins/listener/src/commands.rs, plugins/listener/src/ext.rs
Updates import statements to use actors::SessionParams instead of supervisor::SessionParams; consolidates nested imports for session-related types and actor components.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify all references to supervisor::* have been replaced with actors::SessionParams or equivalent
  • Confirm the new session module exists and exports the expected types (SessionParams, SessionContext, etc.)
  • Check that no dead imports remain after removing the supervisor module
  • Ensure public API consumers are not broken by the removal of supervisor re-exports from the public API

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (2 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'just renaming stuffs' is vague and non-descriptive, failing to clearly convey the actual changes involving module reorganization and import path refactoring. Use a more specific title that describes the main change, such as 'Move SessionParams and related types from supervisor to actors module' or 'Refactor session-related imports to actors module'.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether any meaningful explanation of the changeset was included. Add a pull request description explaining the motivation and details of moving session-related types from the supervisor module to the actors module.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch yl-branch-81

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5782c8c and 2e41384.

📒 Files selected for processing (4)
  • plugins/listener/src/actors/mod.rs (1 hunks)
  • plugins/listener/src/commands.rs (1 hunks)
  • plugins/listener/src/ext.rs (1 hunks)
  • plugins/listener/src/lib.rs (0 hunks)
💤 Files with no reviewable changes (1)
  • plugins/listener/src/lib.rs
🧰 Additional context used
🧬 Code graph analysis (1)
plugins/listener/src/ext.rs (1)
plugins/listener/src/actors/session.rs (1)
  • spawn_session_supervisor (60-162)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Redirect rules - hyprnote-storybook
  • GitHub Check: Redirect rules - hyprnote
  • GitHub Check: Header rules - hyprnote-storybook
  • GitHub Check: Header rules - hyprnote
  • GitHub Check: Pages changed - hyprnote-storybook
  • GitHub Check: Pages changed - hyprnote
  • GitHub Check: fmt
  • GitHub Check: ci (linux, depot-ubuntu-22.04-8)
  • GitHub Check: ci (linux, depot-ubuntu-24.04-8)
  • GitHub Check: ci (macos, depot-macos-14)
🔇 Additional comments (3)
plugins/listener/src/ext.rs (1)

8-11: Consolidated actors import looks correct

Bringing spawn_session_supervisor, SessionContext, SessionParams, SourceActor, and SourceMsg under a single crate::actors::{...} import matches the new actors::session / actors::source re-exports and keeps this module’s dependencies localized. No behavioral change here; usage below is consistent with the new path.

plugins/listener/src/commands.rs (1)

1-1: SessionParams import updated to new actors path

Switching to crate::actors::SessionParams aligns this command module with the new actors::session re-export. The rest of the function signatures and usage remain unchanged, so this is a safe, mechanical rename.

plugins/listener/src/actors/mod.rs (1)

3-9: Session module re-export is consistent with existing actors API pattern

Adding mod session; and pub use session::*; mirrors how listener, recorder, and source are exposed, and it cleanly supports the new actors::SessionParams import sites. As long as session doesn’t define items that collide with existing re-exports, this is a straightforward, well-aligned module reorganization.

If you want to be extra sure about name collisions, a quick scan of session.rs for types/functions that share names with those in listener, recorder, or source would confirm everything is clean.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

@yujonglee yujonglee merged commit 41f0f76 into main Nov 26, 2025
13 checks passed
@yujonglee yujonglee deleted the yl-branch-81 branch November 26, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant