feat: remove native titlebar on Linux for custom titlebar support#1935
Merged
feat: remove native titlebar on Linux for custom titlebar support#1935
Conversation
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📝 WalkthroughWalkthroughAdds a Linux-specific conditional to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the native window decorations (titlebar) on Linux by adding
decorations(false)to the window builder, matching the existing behavior on Windows. This allows the app to display a custom titlebar similar to the macOS version instead of the default Linux window manager titlebar.The change follows the existing pattern in
plugins/windows/src/window/v1.rswhere macOS uses overlay titlebar style and Windows already disables decorations.Local Testing Result
Tested locally on Linux - the native titlebar is successfully removed:
Review & Testing Checklist for Human
data-tauri-drag-region)Notes
data-tauri-drag-regionattributes in place for window draggingcnimport inapps/desktop/src/components/main/sidebar/search/index.tsxLink to Devin run
Requested by: yujonglee (@yujonglee)