refactor: rename docs structure file and update imports#2001
refactor: rename docs structure file and update imports#2001ComputelessComputer merged 1 commit intomainfrom
Conversation
📝 WalkthroughWalkthroughThis PR renames the docs structure file from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/src/routes/_view/docs/route.tsx (1)
64-73: Section resolution is more robust; consider reusing it for mobile navThe new case‑insensitive
findplus typedfilteris a solid improvement over indexing by a derived key, and should handle titles like"FAQ"vs"faq"reliably.The only follow‑up I’d suggest is to mirror this logic (or extract a shared helper) in
MobileDocsDrawerinapps/web/src/routes/_view/route.tsx, which still uses the older capitalization‑based lookup. That will keep desktop and mobile docs navigation in sync, especially for newly added sections like FAQ.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
apps/web/src/routes/_view/docs/$.tsx(1 hunks)apps/web/src/routes/_view/docs/-structure.ts(1 hunks)apps/web/src/routes/_view/docs/route.tsx(3 hunks)apps/web/src/routes/_view/route.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx}: Avoid creating a bunch of types/interfaces if they are not shared. Especially for function props, just inline them instead.
Never do manual state management for form/mutation. Use useForm (from tanstack-form) and useQuery/useMutation (from tanstack-query) instead for 99% of cases. Avoid patterns like setError.
If there are many classNames with conditional logic, usecn(import from@hypr/utils). It is similar toclsx. Always pass an array and split by logical grouping.
Usemotion/reactinstead offramer-motion.
Files:
apps/web/src/routes/_view/docs/$.tsxapps/web/src/routes/_view/docs/-structure.tsapps/web/src/routes/_view/docs/route.tsxapps/web/src/routes/_view/route.tsx
**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.ts: Agent implementations should use TypeScript and follow the established architectural patterns defined in the agent framework
Agent communication should use defined message protocols and interfaces
Files:
apps/web/src/routes/_view/docs/-structure.ts
🧠 Learnings (1)
📚 Learning: 2025-11-24T16:32:19.706Z
Learnt from: CR
Repo: fastrepl/hyprnote PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-24T16:32:19.706Z
Learning: Applies to **/*.{ts,tsx} : Use `motion/react` instead of `framer-motion`.
Applied to files:
apps/web/src/routes/_view/docs/$.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: fmt
- GitHub Check: ci (macos, macos-14)
🔇 Additional comments (5)
apps/web/src/routes/_view/docs/-structure.ts (1)
2-7: FAQ section wiring looks consistentAdding
"faq"tosectionsand thefaq: "faq/general"default page fits the existing pattern and matches howdocsStructure.defaultPagesis consumed for redirects. Just make sure there's a doc with slug"faq/general"and the expectedsectionlabel so it shows up in navigation as intended.apps/web/src/routes/_view/route.tsx (1)
15-15: Import path update to./docs/-structurelooks correctThe new import path correctly targets the renamed docs structure file and keeps
MobileDocsDrawerusing the shared structure.apps/web/src/routes/_view/docs/$.tsx (1)
5-5: Docs route now correctly imports from./-structureUsing
docsStructurefrom the renamed-structuremodule keeps thebeforeLoadredirect logic intact without any behavioral change.apps/web/src/routes/_view/docs/route.tsx (2)
10-10: Shared docsStructure import is aligned with other routesImporting
docsStructurefrom./-structurehere matches the other docs routes and centralizes section configuration correctly.
113-117: DocsNavigation padding adjustment is straightforwardUpdating the link classes to use
pl-5 pr-3instead ofpx-3is a safe, purely visual tweak and doesn’t affect routing or behavior.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
No description provided.