feat(ui): update contribute banner links to GitHub issues#2038
feat(ui): update contribute banner links to GitHub issues#2038ComputelessComputer merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThree route components are updated to redirect contribution links from local content paths to prefilled GitHub issues URLs, with accompanying anchor text updates from "Open on GitHub" to "Submit your idea" across gallery, shortcuts, and templates pages. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
apps/web/src/routes/_view/templates/index.tsx (1)
432-455: Card copy still mentions PRs while link now opens an issueThe card text says “Submit a PR and help the community”, but the CTA now opens a prefilled GitHub issue and the button label is “Submit your idea”. To avoid confusing users, I’d align the body copy with the issue-based flow, e.g.:
- <p className="text-sm text-neutral-500 mb-4"> - Have a template idea? Submit a PR and help the community. - </p> + <p className="text-sm text-neutral-500 mb-4"> + Have a template idea? Submit your idea and help the community. + </p>apps/web/src/routes/_view/gallery/index.tsx (1)
538-559: Update gallery card copy to match the new issue-based contribution flowHere the description still says “Submit a PR and help the community” while the link opens a prefilled issue and the button text is “Submit your idea”. Suggest aligning the wording with the actual flow, e.g.:
- <p className="text-sm text-neutral-500 mb-4"> - Have an idea? Submit a PR and help the community. - </p> + <p className="text-sm text-neutral-500 mb-4"> + Have an idea? Submit your idea and help the community. + </p>apps/web/src/routes/_view/shortcuts/index.tsx (1)
421-443: Shortcut card text should not reference PRs now that it opens an issueSimilar to the templates and gallery cards, this copy still tells users to “Submit a PR” even though the CTA opens a new issue and the button label is “Submit your idea”. Recommend updating the sentence to reflect the issue-based contribution flow, for example:
- <p className="text-sm text-neutral-500 mb-4"> - Have a shortcut idea? Submit a PR and help the community. - </p> + <p className="text-sm text-neutral-500 mb-4"> + Have a shortcut idea? Submit your idea and help the community. + </p>
🧹 Nitpick comments (2)
apps/web/src/routes/_view/templates/index.tsx (1)
154-175: Contribute banner URL and behavior look correct; consider centralizing the templateThe updated banner now goes straight to a prefilled “Suggest New Template” issue with proper
target="_blank"andrel="noopener noreferrer", which matches the PR goal. If you plan to adjust this template again or reuse variants elsewhere, consider extracting a small helper/constant for the issue URL/body instead of duplicating the long encoded string in multiple components.apps/web/src/routes/_view/gallery/index.tsx (1)
198-219: Gallery banner GitHub issue link is fine; minor optional tweak to default typeThe new banner correctly links to a prefilled “Suggest New Template/Shortcut” issue and keeps the external-link attributes consistent. Note that the body currently defaults to
Type: templateeven though the copy invites both template and shortcut ideas; if you want to avoid biasing suggestions, you could change the stub to something likeType: template or shortcutor leave it blank for the user to fill.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/web/src/routes/_view/gallery/index.tsx(3 hunks)apps/web/src/routes/_view/shortcuts/index.tsx(3 hunks)apps/web/src/routes/_view/templates/index.tsx(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx}: Avoid creating a bunch of types/interfaces if they are not shared. Especially for function props, just inline them instead.
Never do manual state management for form/mutation. Use useForm (from tanstack-form) and useQuery/useMutation (from tanstack-query) instead for 99% of cases. Avoid patterns like setError.
If there are many classNames with conditional logic, usecn(import from@hypr/utils). It is similar toclsx. Always pass an array and split by logical grouping.
Usemotion/reactinstead offramer-motion.
Files:
apps/web/src/routes/_view/gallery/index.tsxapps/web/src/routes/_view/shortcuts/index.tsxapps/web/src/routes/_view/templates/index.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Redirect rules - hyprnote
- GitHub Check: Header rules - hyprnote
- GitHub Check: Pages changed - hyprnote
- GitHub Check: fmt
- GitHub Check: ci
🔇 Additional comments (1)
apps/web/src/routes/_view/shortcuts/index.tsx (1)
151-173: Shortcut contribute banner URL matches the intended issue templateThe banner now opens a prefilled “Suggest New Shortcut” issue with correctly encoded body and safe external-link attributes. This is consistent with the shortcuts context and the other routes; no further changes needed here.
1 participant
No description provided.