optimize static route generation and SSR configuration#2181
optimize static route generation and SSR configuration#2181ComputelessComputer wants to merge 4 commits intomainfrom
Conversation
|
Warning Rate limit exceeded@ComputelessComputer has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 25 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated prerender predicate in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for hyprnote failed.
|
0f0b56d to
136c412
Compare
a444dad to
197a48a
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/web/content/legal/dpa.mdx (1)
32-35: Privacy URL update looks good; wording tweak is optionalPointing to
/privacyinstead of/privacy-policykeeps this DPA consistent with the rest of the PR. You might optionally simplify the sentence to “before enabling cloud-based features” instead of “prior to enabling cloud-based features,” but that’s purely stylistic.Please just double‑check that
/privacyis the canonical in‑app route and that there are no remaining important references to/privacy-policyelsewhere.apps/web/vite.config.ts (1)
26-45: Prerender filter logic is sound; consider hoisting route lists and confirm coverageThe new filter correctly:
- Skips dynamic sections (
/api,/webhook,/app,/callback,/t,/newand their subpaths), and- Skips specific external redirect endpoints under
/download.This should reduce accidental prerendering of SSR/dynamic or redirect routes.
Two minor suggestions:
- Hoist
dynamicRoutesandexternalRedirectRoutesout of thefilterfunction so they aren’t reallocated on every call and can be reused elsewhere if needed.- Double‑check that this list fully matches the router / redirect definitions (e.g., if there are other dynamic bases or download variants that should also be excluded).
Please verify against your route config and any redirect handlers that all intended dynamic/redirect paths are covered and no legitimate static routes are accidentally filtered out.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
apps/web/content/articles/is-fireflies-ai-safe.mdx(1 hunks)apps/web/content/docs/about/1.what-is-hyprnote.mdx(1 hunks)apps/web/content/docs/developers/2.login.mdx(1 hunks)apps/web/content/docs/pro/2.cloud.mdx(1 hunks)apps/web/content/legal/dpa.mdx(1 hunks)apps/web/vite.config.ts(2 hunks)
✅ Files skipped from review due to trivial changes (2)
- apps/web/content/docs/pro/2.cloud.mdx
- apps/web/content/articles/is-fireflies-ai-safe.mdx
🧰 Additional context used
📓 Path-based instructions (3)
**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.ts: Agent implementations should use TypeScript and follow the established architectural patterns defined in the agent framework
Agent communication should use defined message protocols and interfaces
Files:
apps/web/vite.config.ts
**/*.config.{ts,json}
📄 CodeRabbit inference engine (CLAUDE.md)
Agent configuration should be centralized and externalized from implementation logic
Files:
apps/web/vite.config.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx}: Avoid creating a bunch of types/interfaces if they are not shared. Especially for function props, just inline them instead.
Never do manual state management for form/mutation. Use useForm (from tanstack-form) and useQuery/useMutation (from tanstack-query) instead for 99% of cases. Avoid patterns like setError.
If there are many classNames with conditional logic, usecn(import from@hypr/utils). It is similar toclsx. Always pass an array and split by logical grouping.
Usemotion/reactinstead offramer-motion.
Files:
apps/web/vite.config.ts
🪛 LanguageTool
apps/web/content/legal/dpa.mdx
[style] ~34-~34: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ... a clear and conspicuous privacy notice prior to enabling cloud-based features, specifyi...
(EN_WORDINESS_PREMIUM_PRIOR_TO)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Redirect rules - hyprnote
- GitHub Check: Header rules - hyprnote
- GitHub Check: fmt
- GitHub Check: ci
- GitHub Check: Pages changed - hyprnote
🔇 Additional comments (3)
apps/web/content/docs/developers/2.login.mdx (1)
13-13: Internal Environment Variables link is an improvement—just verify target pathSwitching to
/docs/developers/envis nicer than an external docs URL and matches the rest of the docs restructuring.Please confirm that the
/docs/developers/envpage exists in this repo and that this is the canonical path used elsewhere (e.g., viarg "/docs/developers/env").apps/web/content/docs/about/1.what-is-hyprnote.mdx (1)
11-13: Updated /docs/about links look consistent with the new docs structureThe new
/docs/about/why-local-firstand/docs/about/why-self-hostedURLs fit the docs reorganization and keep users within the same docs section.Please verify that both target MDX pages exist and that other references to these topics also use the
/docs/about/...paths for consistency.apps/web/vite.config.ts (1)
54-55: Addingmdx-bundlertossr.noExternalis reasonable—just confirm SSR build behaviorIncluding
"mdx-bundler"alongside the other entries inssr.noExternalis a typical fix for SSR bundling issues with that package.After this change, please run your SSR build/dev flow to confirm there are no remaining
mdx-bundlerimport/bundling warnings or runtime errors.
f30ac12 to
a60e3a1
Compare
No description provided.