Skip to content

optimize static route generation and SSR configuration#2181

Closed
ComputelessComputer wants to merge 4 commits intomainfrom
feat/add-download-oss-friends-routes
Closed

optimize static route generation and SSR configuration#2181
ComputelessComputer wants to merge 4 commits intomainfrom
feat/add-download-oss-friends-routes

Conversation

@ComputelessComputer
Copy link
Collaborator

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

Warning

Rate limit exceeded

@ComputelessComputer has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ba57411 and a60e3a1.

📒 Files selected for processing (2)
  • .npmrc (1 hunks)
  • apps/web/vite.config.ts (2 hunks)
📝 Walkthrough

Walkthrough

Updated prerender predicate in apps/web/vite.config.ts to exclude dynamic and external redirect routes instead of using a hard-coded list. Several MDX files had internal link/URL updates (including privacy and docs paths). No SSR externals were changed.

Changes

Cohort / File(s) Summary
Vite prerender config
apps/web/vite.config.ts
Replaced static prerender exclusion list with predicate logic that excludes paths matching dynamicRoutes (and their subpaths) and exact externalRedirectRoutes.
Docs — content link updates
apps/web/content/articles/is-fireflies-ai-safe.mdx, apps/web/content/docs/about/1.what-is-hyprnote.mdx, apps/web/content/docs/developers/2.login.mdx, apps/web/content/docs/pro/2.cloud.mdx, apps/web/content/legal/dpa.mdx
Updated internal links and one privacy link text/target: legacy routes replaced with /docs/..., /privacy, and /pricing as appropriate.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Review prerender predicate in apps/web/vite.config.ts for correct matching of dynamic routes and subpaths.
  • Verify updated MDX links point to existing targets and relative paths resolve.

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims optimization of static route generation and SSR configuration, but the actual changes are primarily URL/path updates across documentation files and prerender filter logic adjustments, not optimization work. Update the title to accurately reflect the main changes, such as 'Update documentation links and prerender filter configuration' or similar.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate whether the description relates to the changeset. Add a detailed pull request description explaining the motivation, changes made, and impact of this PR.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link

netlify bot commented Dec 9, 2025

Deploy Preview for hyprnote-storybook ready!

Name Link
🔨 Latest commit a60e3a1
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/6937b27ac4ecf100087bfdb1
😎 Deploy Preview https://deploy-preview-2181--hyprnote-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 9, 2025

Deploy Preview for hyprnote failed.

Name Link
🔨 Latest commit a60e3a1
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/6937b27a4f92440008dc9e8e

@ComputelessComputer ComputelessComputer force-pushed the feat/add-download-oss-friends-routes branch from 0f0b56d to 136c412 Compare December 9, 2025 03:46
@ComputelessComputer ComputelessComputer changed the title feat(routing): add download and oss-friends routes to static paths optimize static route generation and SSR configuration Dec 9, 2025
@ComputelessComputer ComputelessComputer force-pushed the feat/add-download-oss-friends-routes branch 3 times, most recently from a444dad to 197a48a Compare December 9, 2025 04:39
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
apps/web/content/legal/dpa.mdx (1)

32-35: Privacy URL update looks good; wording tweak is optional

Pointing to /privacy instead of /privacy-policy keeps this DPA consistent with the rest of the PR. You might optionally simplify the sentence to “before enabling cloud-based features” instead of “prior to enabling cloud-based features,” but that’s purely stylistic.

Please just double‑check that /privacy is the canonical in‑app route and that there are no remaining important references to /privacy-policy elsewhere.

apps/web/vite.config.ts (1)

26-45: Prerender filter logic is sound; consider hoisting route lists and confirm coverage

The new filter correctly:

  • Skips dynamic sections (/api, /webhook, /app, /callback, /t, /new and their subpaths), and
  • Skips specific external redirect endpoints under /download.

This should reduce accidental prerendering of SSR/dynamic or redirect routes.

Two minor suggestions:

  • Hoist dynamicRoutes and externalRedirectRoutes out of the filter function so they aren’t reallocated on every call and can be reused elsewhere if needed.
  • Double‑check that this list fully matches the router / redirect definitions (e.g., if there are other dynamic bases or download variants that should also be excluded).

Please verify against your route config and any redirect handlers that all intended dynamic/redirect paths are covered and no legitimate static routes are accidentally filtered out.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f0b56d and 197a48a.

📒 Files selected for processing (6)
  • apps/web/content/articles/is-fireflies-ai-safe.mdx (1 hunks)
  • apps/web/content/docs/about/1.what-is-hyprnote.mdx (1 hunks)
  • apps/web/content/docs/developers/2.login.mdx (1 hunks)
  • apps/web/content/docs/pro/2.cloud.mdx (1 hunks)
  • apps/web/content/legal/dpa.mdx (1 hunks)
  • apps/web/vite.config.ts (2 hunks)
✅ Files skipped from review due to trivial changes (2)
  • apps/web/content/docs/pro/2.cloud.mdx
  • apps/web/content/articles/is-fireflies-ai-safe.mdx
🧰 Additional context used
📓 Path-based instructions (3)
**/*.ts

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.ts: Agent implementations should use TypeScript and follow the established architectural patterns defined in the agent framework
Agent communication should use defined message protocols and interfaces

Files:

  • apps/web/vite.config.ts
**/*.config.{ts,json}

📄 CodeRabbit inference engine (CLAUDE.md)

Agent configuration should be centralized and externalized from implementation logic

Files:

  • apps/web/vite.config.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Avoid creating a bunch of types/interfaces if they are not shared. Especially for function props, just inline them instead.
Never do manual state management for form/mutation. Use useForm (from tanstack-form) and useQuery/useMutation (from tanstack-query) instead for 99% of cases. Avoid patterns like setError.
If there are many classNames with conditional logic, use cn (import from @hypr/utils). It is similar to clsx. Always pass an array and split by logical grouping.
Use motion/react instead of framer-motion.

Files:

  • apps/web/vite.config.ts
🪛 LanguageTool
apps/web/content/legal/dpa.mdx

[style] ~34-~34: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ... a clear and conspicuous privacy notice prior to enabling cloud-based features, specifyi...

(EN_WORDINESS_PREMIUM_PRIOR_TO)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Redirect rules - hyprnote
  • GitHub Check: Header rules - hyprnote
  • GitHub Check: fmt
  • GitHub Check: ci
  • GitHub Check: Pages changed - hyprnote
🔇 Additional comments (3)
apps/web/content/docs/developers/2.login.mdx (1)

13-13: Internal Environment Variables link is an improvement—just verify target path

Switching to /docs/developers/env is nicer than an external docs URL and matches the rest of the docs restructuring.

Please confirm that the /docs/developers/env page exists in this repo and that this is the canonical path used elsewhere (e.g., via rg "/docs/developers/env").

apps/web/content/docs/about/1.what-is-hyprnote.mdx (1)

11-13: Updated /docs/about links look consistent with the new docs structure

The new /docs/about/why-local-first and /docs/about/why-self-hosted URLs fit the docs reorganization and keep users within the same docs section.

Please verify that both target MDX pages exist and that other references to these topics also use the /docs/about/... paths for consistency.

apps/web/vite.config.ts (1)

54-55: Adding mdx-bundler to ssr.noExternal is reasonable—just confirm SSR build behavior

Including "mdx-bundler" alongside the other entries in ssr.noExternal is a typical fix for SSR bundling issues with that package.

After this change, please run your SSR build/dev flow to confirm there are no remaining mdx-bundler import/bundling warnings or runtime errors.

@ComputelessComputer ComputelessComputer force-pushed the feat/add-download-oss-friends-routes branch from f30ac12 to a60e3a1 Compare December 9, 2025 05:24
@yujonglee yujonglee closed this Dec 9, 2025
@yujonglee yujonglee deleted the feat/add-download-oss-friends-routes branch December 9, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants