Skip to content

Comments

Apply changes from PR #2232 (excluding apps/desktop and packages)#2364

Closed
devin-ai-integration[bot] wants to merge 15 commits intomainfrom
devin/1765966275-apply-pr-2232-changes
Closed

Apply changes from PR #2232 (excluding apps/desktop and packages)#2364
devin-ai-integration[bot] wants to merge 15 commits intomainfrom
devin/1765966275-apply-pr-2232-changes

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Dec 17, 2025

Summary

This PR applies changes from PR #2232 to the hyprnote repo, excluding apps/desktop and packages directories. The changes include:

Plugin updates:

  • plugins/permissions: Added ext.rs with permission check/request methods. Fixed Linux CI error by adding From<hypr_audio::Error> to the Error enum.
  • plugins/apple-calendar: Refactored with contact resolver, modular extraction helpers, and new error variants
  • Updated: analytics, cli2, deeplink2, detect, hooks, importer, listener, local-stt, misc, network, notification, store2, template, tray, webhook, windows
  • Deleted: auth, icon, settings, updater2 plugins

Crate updates:

  • Updated: am, audio, buffer, detect, device-heuristic, file, intercept, llama, template, whisper-local, ws, notification-related crates
  • Deleted: granola, notification-gpui crates

CI/CD:

  • Updated GitHub workflows and actions
  • Added devin_changelog workflow

Updates since last revision

  • Fixed pnpm version mismatch: Updated .github/actions/pnpm_install/action.yaml to use pnpm 10.26.0 (matching package.json) instead of 10.25.0. This was causing all CI checks to fail with "Multiple versions of pnpm specified" error.

Review & Testing Checklist for Human

  • Verify the From<hypr_audio::Error> fix in plugins/permissions/src/error.rs - I added this to fix the Linux CI error from the original PR. This was NOT in the original diff - confirm this is the correct approach and doesn't break macOS builds.
  • Check that deleted plugins (auth, icon, settings, updater2) and crates (granola, notification-gpui) aren't referenced elsewhere - The Cargo.toml was updated but verify no orphaned references remain.
  • Verify windows plugin changes - New window types (Settings, Auth, Chat) were added and window sizing logic changed significantly. Test that windows open correctly with proper sizes.
  • Verify pnpm version 10.26.0 is correct - I updated the CI action to match package.json, but confirm this is the intended version.

Recommended test plan:

  1. Wait for CI checks to pass on both macOS and Linux
  2. If CI passes, do a local build on macOS to verify the app compiles and runs
  3. Test that the main window, settings, and other windows open correctly with proper sizing

Notes

  • This PR follows the diff from PR Proper apple calendar support in new bundle #2232 but adds two fixes not in the original:
    1. Adding Audio error variant to permissions plugin (for Linux CI)
    2. Updating pnpm version in CI action (10.25.0 → 10.26.0)
  • The changes were applied in small, self-explanatory commits as requested

Link to Devin run: https://app.devin.ai/sessions/757f5a4ef6e047cdb50cb3741625cdf6
Requested by: yujonglee (yujonglee.dev@gmail.com) (@yujonglee)

devin-ai-integration bot and others added 14 commits December 17, 2025 10:11
- Add PermissionsPluginExt trait with methods for checking and requesting permissions
- Add From<hypr_audio::Error> to Error enum to fix CI error on Linux
- Update commands to use new ext methods
- Add hypr-audio dependency to Cargo.toml

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
…lver

- Add contact_resolver.rs for resolving participant contacts
- Refactor apple.rs with modular extraction helpers and result-based error handling
- Add new error variants (EventNotFound, CalendarNotFound, InvalidDateRange, etc.)
- Add Default impl for CalendarSource
- Add objc2-core-graphics dependency for calendar color extraction
- Update tests to cover calendar and event listing

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- analytics: update ext.rs and commands.rs
- cli2: update ext.rs and handler.rs, remove dependency
- deeplink2: add notification type, update types/mod.rs, add ping command
- detect: update handler.rs, commands.rs, events.rs

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- hooks: update config.rs, ext.rs, commands.rs, runner.rs
- importer: remove sources module, simplify to ping command only
- listener: update viewer.html, events.rs, lib.rs, Cargo.toml
- local-stt: update ext.rs, external.rs, supervisor.rs

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
…te, tray plugins

- misc: update ext.rs
- network: update actor.rs
- notification: update lib.rs, remove handler.rs
- store2: update ext.rs, error.rs, lib.rs
- template: update bindings
- tray: refactor ext.rs, lib.rs, remove menu_items module

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
…ener2, local-llm, sfx, tracing plugins

- webhook: add ping command, update openapi docs
- windows: refactor ext.rs, remove tab module, update window/v1.rs
- db, db2, extensions, listener2, local-llm, sfx, tracing: update bindings

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
These plugins have been removed as part of the refactoring.

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
… file, intercept, llama, template, whisper-local, ws crates

- am: update client.rs and types.rs
- audio: update norm.rs and speaker/linux.rs
- buffer: update lib.rs
- detect: update app/linux.rs, lib.rs, list/linux.rs, list/macos.rs, mic/linux.rs, mic/macos.rs
- device-heuristic: update linux.rs
- file: update lib.rs
- intercept: update lib.rs
- llama: update lib.rs and parser.rs
- template: update lib.rs, remove highlight templates
- whisper-local: update model/actual.rs
- ws: update client.rs

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- notification: update Cargo.toml and lib.rs
- notification-interface: update lib.rs
- notification-linux: update impl.rs and lib.rs
- notification-macos: update lib.rs and swift-lib/src/lib.swift

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
These crates have been removed as part of the refactoring.

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- Update API.md, build.ts, generate.ts, runtime.ts

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- Update pnpm_install action
- Update rust_install action
- Update desktop_cd workflow
- Add devin_changelog workflow
- Update fmt workflow

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- Update workspace dependencies
- Remove references to deleted crates (granola, notification-gpui)
- Remove references to deleted plugins (auth, icon, settings, updater2)

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 17, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link

netlify bot commented Dec 17, 2025

Deploy Preview for hyprnote-storybook ready!

Name Link
🔨 Latest commit 29eb93e
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/6942852310e17a000819582f
😎 Deploy Preview https://deploy-preview-2364--hyprnote-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 17, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit 29eb93e
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/694285238791f40007aa6188
😎 Deploy Preview https://deploy-preview-2364--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
@yujonglee yujonglee closed this Dec 17, 2025
@yujonglee yujonglee deleted the devin/1765966275-apply-pr-2232-changes branch December 17, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant