Apply changes from PR #2232 (excluding apps/desktop and packages)#2364
Closed
devin-ai-integration[bot] wants to merge 15 commits intomainfrom
Closed
Apply changes from PR #2232 (excluding apps/desktop and packages)#2364devin-ai-integration[bot] wants to merge 15 commits intomainfrom
devin-ai-integration[bot] wants to merge 15 commits intomainfrom
Conversation
- Add PermissionsPluginExt trait with methods for checking and requesting permissions - Add From<hypr_audio::Error> to Error enum to fix CI error on Linux - Update commands to use new ext methods - Add hypr-audio dependency to Cargo.toml Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
…lver - Add contact_resolver.rs for resolving participant contacts - Refactor apple.rs with modular extraction helpers and result-based error handling - Add new error variants (EventNotFound, CalendarNotFound, InvalidDateRange, etc.) - Add Default impl for CalendarSource - Add objc2-core-graphics dependency for calendar color extraction - Update tests to cover calendar and event listing Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- analytics: update ext.rs and commands.rs - cli2: update ext.rs and handler.rs, remove dependency - deeplink2: add notification type, update types/mod.rs, add ping command - detect: update handler.rs, commands.rs, events.rs Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- hooks: update config.rs, ext.rs, commands.rs, runner.rs - importer: remove sources module, simplify to ping command only - listener: update viewer.html, events.rs, lib.rs, Cargo.toml - local-stt: update ext.rs, external.rs, supervisor.rs Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
…te, tray plugins - misc: update ext.rs - network: update actor.rs - notification: update lib.rs, remove handler.rs - store2: update ext.rs, error.rs, lib.rs - template: update bindings - tray: refactor ext.rs, lib.rs, remove menu_items module Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
…ener2, local-llm, sfx, tracing plugins - webhook: add ping command, update openapi docs - windows: refactor ext.rs, remove tab module, update window/v1.rs - db, db2, extensions, listener2, local-llm, sfx, tracing: update bindings Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
These plugins have been removed as part of the refactoring. Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
… file, intercept, llama, template, whisper-local, ws crates - am: update client.rs and types.rs - audio: update norm.rs and speaker/linux.rs - buffer: update lib.rs - detect: update app/linux.rs, lib.rs, list/linux.rs, list/macos.rs, mic/linux.rs, mic/macos.rs - device-heuristic: update linux.rs - file: update lib.rs - intercept: update lib.rs - llama: update lib.rs and parser.rs - template: update lib.rs, remove highlight templates - whisper-local: update model/actual.rs - ws: update client.rs Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- notification: update Cargo.toml and lib.rs - notification-interface: update lib.rs - notification-linux: update impl.rs and lib.rs - notification-macos: update lib.rs and swift-lib/src/lib.swift Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
These crates have been removed as part of the refactoring. Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- Update API.md, build.ts, generate.ts, runtime.ts Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- Update pnpm_install action - Update rust_install action - Update desktop_cd workflow - Add devin_changelog workflow - Update fmt workflow Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
- Update workspace dependencies - Remove references to deleted crates (granola, notification-gpui) - Remove references to deleted plugins (auth, icon, settings, updater2) Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies changes from PR #2232 to the hyprnote repo, excluding
apps/desktopandpackagesdirectories. The changes include:Plugin updates:
plugins/permissions: Addedext.rswith permission check/request methods. Fixed Linux CI error by addingFrom<hypr_audio::Error>to the Error enum.plugins/apple-calendar: Refactored with contact resolver, modular extraction helpers, and new error variantsCrate updates:
CI/CD:
Updates since last revision
.github/actions/pnpm_install/action.yamlto use pnpm 10.26.0 (matching package.json) instead of 10.25.0. This was causing all CI checks to fail with "Multiple versions of pnpm specified" error.Review & Testing Checklist for Human
From<hypr_audio::Error>fix inplugins/permissions/src/error.rs- I added this to fix the Linux CI error from the original PR. This was NOT in the original diff - confirm this is the correct approach and doesn't break macOS builds.Recommended test plan:
Notes
Audioerror variant to permissions plugin (for Linux CI)Link to Devin run: https://app.devin.ai/sessions/757f5a4ef6e047cdb50cb3741625cdf6
Requested by: yujonglee (yujonglee.dev@gmail.com) (@yujonglee)