Skip to content

Remove focus ring and shadow from select inputs#2422

Merged
ComputelessComputer merged 1 commit intomainfrom
style/remove-select-input-styles
Dec 19, 2025
Merged

Remove focus ring and shadow from select inputs#2422
ComputelessComputer merged 1 commit intomainfrom
style/remove-select-input-styles

Conversation

@ComputelessComputer
Copy link
Collaborator

• Removed focus ring and shadow from select input elements
• Improved UI styling for select inputs

@netlify
Copy link

netlify bot commented Dec 19, 2025

Deploy Preview for hyprnote-storybook ready!

Name Link
🔨 Latest commit 370d5b8
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/6944f570ccf3f800087ddb06
😎 Deploy Preview https://deploy-preview-2422--hyprnote-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 19, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit 370d5b8
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/6944f5704e2c2a0008b7a592
😎 Deploy Preview https://deploy-preview-2422--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 19, 2025

📝 Walkthrough

Walkthrough

This PR updates CSS styling across three AI settings UI components. SelectTrigger and Button elements receive additional shadow-none and focus-ring removal classes to modify their visual appearance. No functional logic or control flow changes are introduced; only presentation layer updates.

Changes

Cohort / File(s) Summary
AI Settings UI Styling Updates
apps/desktop/src/components/settings/ai/llm/select.tsx, apps/desktop/src/components/settings/ai/shared/model-combobox.tsx, apps/desktop/src/components/settings/ai/stt/select.tsx
Adds shadow-none and focus:ring-0 / focus-visible:ring-0 CSS classes to SelectTrigger and Button components to remove default shadow and focus ring styling

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2–5 minutes

  • Simple, repetitive CSS class additions across three files with no logic or behavioral changes

Possibly related PRs

Suggested reviewers

  • yujonglee

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove focus ring and shadow from select inputs' accurately and concisely summarizes the main change, which is removing CSS styling (focus ring and shadow) from select input elements across three files.
Description check ✅ Passed The description clearly relates to the changeset by describing the removal of focus ring and shadow from select inputs and improved UI styling, which aligns with the actual CSS class modifications across the three modified files.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch style/remove-select-input-styles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3ec983 and 370d5b8.

📒 Files selected for processing (3)
  • apps/desktop/src/components/settings/ai/llm/select.tsx (1 hunks)
  • apps/desktop/src/components/settings/ai/shared/model-combobox.tsx (1 hunks)
  • apps/desktop/src/components/settings/ai/stt/select.tsx (2 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*

📄 CodeRabbit inference engine (AGENTS.md)

Format using dprint fmt from the root. Do not use cargo fmt.

Files:

  • apps/desktop/src/components/settings/ai/llm/select.tsx
  • apps/desktop/src/components/settings/ai/shared/model-combobox.tsx
  • apps/desktop/src/components/settings/ai/stt/select.tsx
**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Avoid creating a bunch of types/interfaces if they are not shared. Especially for function props. Just inline them.
Never do manual state management for form/mutation. Use useForm from tanstack-form and useQuery/useMutation from tanstack-query for 99% cases.

Files:

  • apps/desktop/src/components/settings/ai/llm/select.tsx
  • apps/desktop/src/components/settings/ai/shared/model-combobox.tsx
  • apps/desktop/src/components/settings/ai/stt/select.tsx
**/*.{ts,tsx,rs,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

By default, avoid writing comments at all. If you write one, it should be about 'Why', not 'What'.

Files:

  • apps/desktop/src/components/settings/ai/llm/select.tsx
  • apps/desktop/src/components/settings/ai/shared/model-combobox.tsx
  • apps/desktop/src/components/settings/ai/stt/select.tsx
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx}: If there are many classNames with conditional logic, use cn (import from @hypr/utils). Always pass an array and split by logical grouping.
Use motion/react instead of framer-motion.

Files:

  • apps/desktop/src/components/settings/ai/llm/select.tsx
  • apps/desktop/src/components/settings/ai/shared/model-combobox.tsx
  • apps/desktop/src/components/settings/ai/stt/select.tsx
🧬 Code graph analysis (3)
apps/desktop/src/components/settings/ai/llm/select.tsx (1)
extensions/shared/types/hypr-extension.d.ts (1)
  • SelectTrigger (409-409)
apps/desktop/src/components/settings/ai/shared/model-combobox.tsx (1)
packages/utils/src/cn.ts (1)
  • cn (20-22)
apps/desktop/src/components/settings/ai/stt/select.tsx (1)
extensions/shared/types/hypr-extension.d.ts (1)
  • SelectTrigger (409-409)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Redirect rules - hyprnote
  • GitHub Check: Header rules - hyprnote
  • GitHub Check: Pages changed - hyprnote
  • GitHub Check: desktop_ci (linux, depot-ubuntu-24.04-8)
  • GitHub Check: desktop_ci (linux, depot-ubuntu-22.04-8)
  • GitHub Check: desktop_ci (macos, depot-macos-14)
  • GitHub Check: fmt

@ComputelessComputer ComputelessComputer merged commit 6edfb16 into main Dec 19, 2025
16 checks passed
@ComputelessComputer ComputelessComputer deleted the style/remove-select-input-styles branch December 19, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant