Remove focus ring and shadow from select inputs#2422
Remove focus ring and shadow from select inputs#2422ComputelessComputer merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis PR updates CSS styling across three AI settings UI components. SelectTrigger and Button elements receive additional shadow-none and focus-ring removal classes to modify their visual appearance. No functional logic or control flow changes are introduced; only presentation layer updates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2–5 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/desktop/src/components/settings/ai/llm/select.tsx(1 hunks)apps/desktop/src/components/settings/ai/shared/model-combobox.tsx(1 hunks)apps/desktop/src/components/settings/ai/stt/select.tsx(2 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*
📄 CodeRabbit inference engine (AGENTS.md)
Format using
dprint fmtfrom the root. Do not usecargo fmt.
Files:
apps/desktop/src/components/settings/ai/llm/select.tsxapps/desktop/src/components/settings/ai/shared/model-combobox.tsxapps/desktop/src/components/settings/ai/stt/select.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx}: Avoid creating a bunch of types/interfaces if they are not shared. Especially for function props. Just inline them.
Never do manual state management for form/mutation. UseuseFormfrom tanstack-form anduseQuery/useMutationfrom tanstack-query for 99% cases.
Files:
apps/desktop/src/components/settings/ai/llm/select.tsxapps/desktop/src/components/settings/ai/shared/model-combobox.tsxapps/desktop/src/components/settings/ai/stt/select.tsx
**/*.{ts,tsx,rs,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
By default, avoid writing comments at all. If you write one, it should be about 'Why', not 'What'.
Files:
apps/desktop/src/components/settings/ai/llm/select.tsxapps/desktop/src/components/settings/ai/shared/model-combobox.tsxapps/desktop/src/components/settings/ai/stt/select.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,js,jsx}: If there are many classNames with conditional logic, usecn(import from@hypr/utils). Always pass an array and split by logical grouping.
Usemotion/reactinstead offramer-motion.
Files:
apps/desktop/src/components/settings/ai/llm/select.tsxapps/desktop/src/components/settings/ai/shared/model-combobox.tsxapps/desktop/src/components/settings/ai/stt/select.tsx
🧬 Code graph analysis (3)
apps/desktop/src/components/settings/ai/llm/select.tsx (1)
extensions/shared/types/hypr-extension.d.ts (1)
SelectTrigger(409-409)
apps/desktop/src/components/settings/ai/shared/model-combobox.tsx (1)
packages/utils/src/cn.ts (1)
cn(20-22)
apps/desktop/src/components/settings/ai/stt/select.tsx (1)
extensions/shared/types/hypr-extension.d.ts (1)
SelectTrigger(409-409)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Redirect rules - hyprnote
- GitHub Check: Header rules - hyprnote
- GitHub Check: Pages changed - hyprnote
- GitHub Check: desktop_ci (linux, depot-ubuntu-24.04-8)
- GitHub Check: desktop_ci (linux, depot-ubuntu-22.04-8)
- GitHub Check: desktop_ci (macos, depot-macos-14)
- GitHub Check: fmt
• Removed focus ring and shadow from select input elements
• Improved UI styling for select inputs