Validate fix for transcript multi-word search (#3351)#3424
Open
Vanashreeshankar wants to merge 2 commits intofastrepl:mainfrom
Open
Validate fix for transcript multi-word search (#3351)#3424Vanashreeshankar wants to merge 2 commits intofastrepl:mainfrom
Vanashreeshankar wants to merge 2 commits intofastrepl:mainfrom
Conversation
👷 Deploy request for hyprnote pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR - shared to document investigation; not intended to compete with #3423
While investigating issue #3351, I independently traced the root cause of
the transcript search behavior and implemented a minimal fix locally.
This draft is shared to document findings and the proposed solution.
Problem
Transcript search only worked for single-word queries because matching was done
against individual word spans using the full query string.
Root cause
[data-word-id])multi-character / multi-word searches (English & Korean) to fail
Solution
Result
Multi-character and multi-word searches now work for English and Korean.
Notes
Environment note
Full desktop build fails on Windows due to Node memory limits; the change here
is isolated and logic-only.