Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ function ContentInner({ sessionId }: { sessionId: string }) {
const event = useEvent(eventId);

return (
<div className="flex flex-col gap-4 p-4">
<div className="flex flex-col gap-4 p-4 overflow-y-auto">
{event && <EventDisplay event={event} />}
{!event && <DateDisplay sessionId={sessionId} />}
<ParticipantsDisplay sessionId={sessionId} />
Expand Down Expand Up @@ -212,6 +212,15 @@ export function EventDisplay({
{event.startedAt && (
<div className="text-sm text-neutral-700">{formatEventDateTime()}</div>
)}

{event.description && (
<>
<div className="h-px bg-neutral-200" />
<div className="text-sm text-neutral-700 whitespace-pre-wrap break-words">
{event.description}
</div>
</>
)}
Comment on lines +216 to +223
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Calendar view popover lacks max-height/overflow for newly rendered long descriptions

The EventDisplay component now renders the description field (lines 216-223), but it is also used in the calendar view's EventPopoverContent at apps/desktop/src/components/main/body/calendar/calendar-view.tsx:587. That popover's container (PopoverContent at line 552-554) has no max-h or overflow constraints:

<PopoverContent
  align="start"
  className="w-[280px] shadow-lg p-0 rounded-lg"
  onClick={(e) => e.stopPropagation()}
>
Impact and root cause

The metadata popover in the session view was correctly updated with overflow-y-auto on the inner div and already had max-h-[80vh] on the PopoverContent. However, the calendar view's event popover was not updated. When a calendar event has a long description (e.g. 10+ lines of meeting details, LinkedIn URLs, etc.), the popover will grow unbounded and can overflow the viewport, making the "Open note" button inaccessible.

Expected: The calendar event popover should also constrain its height and allow scrolling for long descriptions.

Actual: The popover grows without bounds, potentially extending beyond the viewport.

Prompt for agents
In apps/desktop/src/components/main/body/calendar/calendar-view.tsx, add max-height and overflow constraints to the calendar event PopoverContent (around line 552-554) similar to the metadata popover. For example, add max-h-[80vh] to the PopoverContent className and overflow-y-auto to the inner div in EventPopoverContent (line 586). This ensures long event descriptions don't cause the popover to overflow the viewport.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

</div>
);
}
Expand Down
Loading