-
Notifications
You must be signed in to change notification settings - Fork 538
feat: show event description in metadata chip #3840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,7 +87,7 @@ function ContentInner({ sessionId }: { sessionId: string }) { | |
| const event = useEvent(eventId); | ||
|
|
||
| return ( | ||
| <div className="flex flex-col gap-4 p-4"> | ||
| <div className="flex flex-col gap-4 p-4 overflow-y-auto"> | ||
| {event && <EventDisplay event={event} />} | ||
| {!event && <DateDisplay sessionId={sessionId} />} | ||
| <ParticipantsDisplay sessionId={sessionId} /> | ||
|
|
@@ -212,6 +212,15 @@ export function EventDisplay({ | |
| {event.startedAt && ( | ||
| <div className="text-sm text-neutral-700">{formatEventDateTime()}</div> | ||
| )} | ||
|
|
||
| {event.description && ( | ||
| <> | ||
| <div className="h-px bg-neutral-200" /> | ||
| <div className="text-sm text-neutral-700 whitespace-pre-wrap break-words"> | ||
| {event.description} | ||
| </div> | ||
| </> | ||
| )} | ||
|
Comment on lines
+216
to
+223
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Calendar view popover lacks max-height/overflow for newly rendered long descriptions The <PopoverContent
align="start"
className="w-[280px] shadow-lg p-0 rounded-lg"
onClick={(e) => e.stopPropagation()}
>Impact and root causeThe metadata popover in the session view was correctly updated with Expected: The calendar event popover should also constrain its height and allow scrolling for long descriptions. Actual: The popover grows without bounds, potentially extending beyond the viewport. Prompt for agentsWas this helpful? React with 👍 or 👎 to provide feedback. |
||
| </div> | ||
| ); | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.