Conversation
The changes remove the `hasShownConsent` state from the `ongoingSessionStore`. This state was previously used to track whether the user had seen the consent dialog, but it is no longer needed as the consent dialog logic has been removed from the `listen-button` component. feat(listen-button): simplify consent logic and audio controls The changes in the `listen-button` component simplify the consent logic and audio controls. The `WhenActive` component no longer handles the consent dialog and speaker muting. Instead, it focuses on the session pause and stop functionality. The consent logic and speaker muting have been removed, as they are no longer required.
WalkthroughThe changes remove all logic and UI related to user consent management for recording from the note header's listen button and the ongoing session state store. This includes deleting consent dialogs, consent state management hooks, and related state properties, resulting in a simplified recording control flow without explicit consent tracking. Changes
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/desktop/src/components/editor-area/note-header/listen-button.tsx(3 hunks)packages/utils/src/stores/ongoing-session.ts(0 hunks)
💤 Files with no reviewable changes (1)
- packages/utils/src/stores/ongoing-session.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: ci (windows, windows-latest)
- GitHub Check: ci (macos, macos-latest)
🔇 Additional comments (2)
apps/desktop/src/components/editor-area/note-header/listen-button.tsx (2)
202-202: Function export removal looks correct.The removal of the
exportkeyword from theWhenActivefunction is appropriate since it appears to be used only within this file after the refactoring.
235-239: RecordingControls simplification looks good.The component props have been appropriately simplified to remove consent-related parameters while maintaining the core recording functionality.
|
@yujonglee good to go |
The changes remove the
hasShownConsentstate from theongoingSessionStore. This state was previously used to track whether the user had seen the consent dialog, but it is no longer needed as the consent dialog logic has been removed from thelisten-buttoncomponent.feat(listen-button): simplify consent logic and audio controls
The changes in the
listen-buttoncomponent simplify the consent logic and audio controls. TheWhenActivecomponent no longer handles the consent dialog and speaker muting. Instead, it focuses on the session pause and stop functionality. The consent logic and speaker muting have been removed, as they are no longer required.Summary by CodeRabbit
New Features
Refactor