Skip to content

Remove unused hasShownConsent state#894

Merged
yujonglee merged 1 commit intomainfrom
jj-branch-14
May 29, 2025
Merged

Remove unused hasShownConsent state#894
yujonglee merged 1 commit intomainfrom
jj-branch-14

Conversation

@ComputelessComputer
Copy link
Collaborator

@ComputelessComputer ComputelessComputer commented May 28, 2025

The changes remove the hasShownConsent state from the ongoingSessionStore. This state was previously used to track whether the user had seen the consent dialog, but it is no longer needed as the consent dialog logic has been removed from the listen-button component.

feat(listen-button): simplify consent logic and audio controls

The changes in the listen-button component simplify the consent logic and audio controls. The WhenActive component no longer handles the consent dialog and speaker muting. Instead, it focuses on the session pause and stop functionality. The consent logic and speaker muting have been removed, as they are no longer required.

Summary by CodeRabbit

  • New Features

    • Simplified the active recording interface by removing the consent dialog and related prompts.
  • Refactor

    • Streamlined recording controls for a more direct user experience, eliminating consent management steps.

The changes remove the `hasShownConsent` state from the `ongoingSessionStore`. This state was previously used to track whether the user had seen the consent dialog, but it is no longer needed as the consent dialog logic has been removed from the `listen-button` component.

feat(listen-button): simplify consent logic and audio controls

The changes in the `listen-button` component simplify the consent logic and audio controls. The `WhenActive` component no longer handles the consent dialog and speaker muting. Instead, it focuses on the session pause and stop functionality. The consent logic and speaker muting have been removed, as they are no longer required.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 28, 2025

Walkthrough

The changes remove all logic and UI related to user consent management for recording from the note header's listen button and the ongoing session state store. This includes deleting consent dialogs, consent state management hooks, and related state properties, resulting in a simplified recording control flow without explicit consent tracking.

Changes

File(s) Change Summary
apps/desktop/src/components/editor-area/note-header/listen-button.tsx Removed consent dialog, consent management hook, and related state; simplified popover and event logic.
packages/utils/src/stores/ongoing-session.ts Deleted hasShownConsent state and setter; removed all consent tracking from session store.

Poem

🐇
The consent is gone, the flow is light,
No more dialogs in the night.
With simpler code, the bunny cheers,
Recording starts—no extra gears!
State and store are lean and clean,
Hopping forward, swift and keen.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a48c6b1 and 108617f.

📒 Files selected for processing (2)
  • apps/desktop/src/components/editor-area/note-header/listen-button.tsx (3 hunks)
  • packages/utils/src/stores/ongoing-session.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/utils/src/stores/ongoing-session.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: ci (windows, windows-latest)
  • GitHub Check: ci (macos, macos-latest)
🔇 Additional comments (2)
apps/desktop/src/components/editor-area/note-header/listen-button.tsx (2)

202-202: Function export removal looks correct.

The removal of the export keyword from the WhenActive function is appropriate since it appears to be used only within this file after the refactoring.


235-239: RecordingControls simplification looks good.

The component props have been appropriately simplified to remove consent-related parameters while maintaining the core recording functionality.

@ComputelessComputer
Copy link
Collaborator Author

@yujonglee good to go

@yujonglee yujonglee merged commit 7a3725e into main May 29, 2025
5 checks passed
@yujonglee yujonglee deleted the jj-branch-14 branch May 29, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants