-
Notifications
You must be signed in to change notification settings - Fork 538
Overlay floating control [More Improvements] #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yujonglee
merged 12 commits into
fastrepl:overlay-floating-control
from
plyght:overlay-floating-control
Jun 3, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a222b83
coderabbit fixes
plyght 5eb6f90
update
plyght 57bed3d
fix coderabbit
plyght 35a682b
updates/fix
plyght 79b5068
update
plyght bff4521
update
plyght 50cf099
fix minor issues
plyght b65a386
chore: cleanup logs
plyght 7112b0d
remove bun.lock
plyght d407513
update cargo.toml
plyght c0da74f
update coderabbit
plyght 0b4b2e2
Merge branch 'overlay-floating-control' into overlay-floating-control
plyght File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Consider integration with existing functionality or removal.
Both hooks provide functionality that either duplicates existing code or isn't being used. The
useAudioControlshook overlaps with the audio control logic in theRecordingControlscomponent (lines 243-254). Consider either:Let me check if these hooks are used elsewhere in the codebase:
🏁 Script executed:
Length of output: 331
Let’s retry the search across all TypeScript/TSX files with glob patterns:
🏁 Script executed:
Length of output: 328
Review and consolidate unused hooks in listen-button.tsx
The
useConsentManagementanduseAudioControlshooks inapps/desktop/src/components/editor-area/note-header/listen-button.tsx(lines 326–403) are never referenced elsewhere in the codebase. At the same time, theRecordingControlscomponent inapps/desktop/src/components/editor-area/note-header/recording-controls.tsx(around lines 243–254) already implements similar mic/speaker mute logic.Consider one of the following actions:
RecordingControlscomponent so that the shared logic lives in one place.useConsentManagementanduseAudioControlsif they’re not needed today.🤖 Prompt for AI Agents