fix: respect microphone detection disabled setting for prolonged usage notifications #3862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When "Microphone detection" is toggled OFF in notification settings,
micStartednotifications are correctly suppressed (line 78 check), butmicProlongedUsagenotifications ("Meeting in progress? Mic used for X minutes.") continued to fire because they only checked the separatenotification_in_meeting_remindersetting.This adds the missing
notificationDetectEnabledRef.currentguard to themicProlongedUsagehandler, matching the existing pattern used formicStarted.Reported by a user with an always-hot XLR mic who disabled "Microphone detection" but kept receiving detection notifications.
Review & Testing Checklist for Human
micProlongedUsageis logically a child feature of "Microphone detection" and should be suppressed when that toggle is OFF — i.e., there's no valid use case where a user wants prolonged-usage reminders but not mic-started detectionNotes
micStartedpattern but could be optimized separately.