Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Feb 11, 2026

Summary

When "Microphone detection" is toggled OFF in notification settings, micStarted notifications are correctly suppressed (line 78 check), but micProlongedUsage notifications ("Meeting in progress? Mic used for X minutes.") continued to fire because they only checked the separate notification_in_meeting_reminder setting.

This adds the missing notificationDetectEnabledRef.current guard to the micProlongedUsage handler, matching the existing pattern used for micStarted.

Reported by a user with an always-hot XLR mic who disabled "Microphone detection" but kept receiving detection notifications.

Review & Testing Checklist for Human

  • Verify that micProlongedUsage is logically a child feature of "Microphone detection" and should be suppressed when that toggle is OFF — i.e., there's no valid use case where a user wants prolonged-usage reminders but not mic-started detection
  • Test with "Microphone detection" OFF: confirm no prolonged usage notifications appear after ~3 minutes of mic activity
  • Test with "Microphone detection" ON and "In-meeting reminder" OFF: confirm prolonged usage notifications are still suppressed (existing behavior, unchanged)
  • Test with both ON: confirm prolonged usage notifications still work as expected

Notes

  • The Rust-side detector continues to run and emit events even when detection is disabled; the frontend simply ignores them. This is consistent with the existing micStarted pattern but could be optimized separately.
  • Link to Devin run
  • Requested by @ComputelessComputer

Open with Devin

Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
@netlify
Copy link

netlify bot commented Feb 11, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit 234137a
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/698c61a3a815890008297804

@netlify
Copy link

netlify bot commented Feb 11, 2026

Deploy Preview for hyprnote-storybook canceled.

Name Link
🔨 Latest commit 234137a
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/698c61a3d312620008a33374

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Contributor Author

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant