Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Feb 11, 2026

Summary

Expands the Whisper hallucination filter in crates/whisper-local/src/model/actual.rs to suppress more known hallucination phrases that Whisper produces when a channel (mic or speaker) is silent.

The previous filter only did exact-match checks against a handful of strings ("you", "thank you", "you.", "thank you.", "♪"). The new is_hallucination method:

  • Strips trailing/leading punctuation before comparison, so variants like "Thank you!" or "Thank you," are now caught.
  • Adds more exact-match hallucination words: "the", "thanks", "bye", "goodbye", "bye bye", "so", "oh", "uh", "hmm", "ah", "music", and empty strings.
  • Adds prefix-based matching via starts_with to catch common YouTube-training-data hallucinations like "thank you for watching", "thanks for listening", "please subscribe", "subtitles by", etc.

Hallucination list informed by sachaarbonel/whisper-hallucinations dataset of Whisper outputs on noise-only audio.

Review & Testing Checklist for Human

  • False positive risk with starts_with("thank you"): This will filter any segment beginning with "thank you", including legitimate speech like "Thank you, John, for joining us". Verify this is acceptable given that segments are typically short chunks, or consider tightening the match.
  • Short-word exact matches may be aggressive: Single-word matches like "so", "oh", "the" apply to the entire segment text after stripping punctuation. Confirm that real speech segments are unlikely to consist of only these words (they should be fine given VAD chunking, but worth verifying).
  • No unit tests added: The is_hallucination function has no test coverage. Consider adding tests for edge cases (e.g., "Thank you, Sarah" should NOT be filtered, "Thank you for watching" should).
  • End-to-end test: Run the app with a Whisper model, leave mic/speaker silent for 30+ seconds, and verify "Thank you" no longer appears in the transcript.

Notes

Requested by: @ComputelessComputer
Link to Devin run


Open with Devin

Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
@netlify
Copy link

netlify bot commented Feb 11, 2026

Deploy Preview for hyprnote-storybook canceled.

Name Link
🔨 Latest commit c49f0b4
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/698cc0ec9438f40008ec1ea9

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link

netlify bot commented Feb 11, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit c49f0b4
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/698cc0ec5c2e6d000849c42d

Copy link
Contributor Author

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant