Copy Gemfile.lock on --init
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We initialize the Gemfile.next.lock by copying the content of the existing Gemfile.lock. This prevents major version jumps when we use this gem without an initial Gemfile.next.lock. This commit closes: #24
etagwerker
requested changes
Oct 22, 2021
|
|
||
| Execute: | ||
|
|
||
| $ next --init |
There was a problem hiding this comment.
@fbuys I think it would be great if you can add what will happen after you execute next --init -- I realize it is documented above in line 86.
I just think it would be great to add the reasoning behind starting with Gemfile.lock as the base lockfile (as explained by @arielj in our internal communications) 😄
There was a problem hiding this comment.
Good idea! I hesitated to do that because the existing README seems pretty short.
So users are aware that the --init will also create a Gemfile.next.lock.
fbuys
force-pushed
the
fbuys/24-copy-gemfile-lock-file
branch
from
87e6f64 to
2afde42
Compare
etagwerker
approved these changes
Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes: #24
We want to make sure that users start with a Gemfile.next.lock that are not much different from their existing Gemfile.lock.
This prevents major version jump upon using rails_next for the first time with an outdated rails project.