Find latest compatible version when checking compatibility #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
that links to this PR under the "main (unreleased)" heading.Description:
This PR changes how we check the compatibility of gems. Currently, if the current version of a gem is not compatible with the desired Rails version, we check if the latest available version of that gem is compatible with Rails.
This is a problem, because the latest version may not be compatible with the desired Rails version, but there might be other versions between the current and the latest that are compatible.
This PR updates the compatibility check to check all versions from the latest to the current until it finds a compatible version.
How I tested this:
I really don't know how to add an automated test for this, it relies a lot on external data.
What I did to test this was:
next_rail
to the gemfilebundle exec bundle_report compatibility --rails-version=5.0.0
Before this fix:
After this fix:
As expected from the report.
Closes #9
I will abide by the code of conduct.