convert bundle report class to module #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
italomatos
requested review from
bronzdoc and
kindoflew
and removed request for
a team
italomatos
force-pushed
the
convert-bundle-report-class-to-module
branch
from
e22693b to
9a292fc
Compare
mateusdeap
requested review from
hmdros and
kaysiz
and removed request for
kindoflew and
bronzdoc
etagwerker
added a commit
that referenced
this pull request
Oct 28, 2022
|
@italomatos Thanks for submitting this change! I pushed it over here: 0866aa6 |
etagwerker
added a commit
that referenced
this pull request
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR has a goal to convert BundleReport class to Module. Classes have behaviour and data, but in this case is not necessary to be a class, could be a module. Reason is that Class is too heavy for creating only methods.
I will abide by the code of conduct.