Skip to content

Release v1.2.0 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Release v1.2.0 #69

merged 1 commit into from
Aug 12, 2022

Conversation

rishijain
Copy link
Collaborator

Release v1.2.0

@rishijain rishijain requested a review from a team as a code owner August 12, 2022 11:05
@rishijain rishijain requested review from mateusdeap, KostiantynPopovych and kindoflew and removed request for a team August 12, 2022 11:05
Copy link

@fbuys fbuys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, after that I think it is good to go!

# main [(unreleased)](https://github.com/fastruby/next_rails/compare/v1.1.0...main)
# main [(unreleased)](https://github.com/fastruby/next_rails/compare/v1.2.0...main)

# v1.2.0 / 2022-08-12 [(commits)](https://github.com/fastruby/next_rails/compare/v1.1.0...v1.2.0)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, one small thing related to your PR, can we align line 5?
It looks like it has an extra space in front.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @fbuys I looked it up on my editor and here as well https://github.com/fastruby/next_rails/blob/f534dff96eea533e41ec7c00dfaa0f2009dad12b/CHANGELOG.md

It looks aligned to me.

I don't know why it looks off on the diff though.

Copy link

@kindoflew kindoflew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rishijain rishijain merged commit a4a0139 into main Aug 12, 2022
@rishijain rishijain deleted the release/v1-2-0 branch August 12, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants