Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Nested /test or /spec folders are not ignored #60

Closed
2 tasks done
arielj opened this issue Nov 3, 2020 · 1 comment
Closed
2 tasks done

[BUG] Nested /test or /spec folders are not ignored #60

arielj opened this issue Nov 3, 2020 · 1 comment
Assignees
Labels

Comments

@arielj
Copy link

arielj commented Nov 3, 2020

IMPORTANT: please make sure you ask yourself all intro questions and fill all sections of the template.

Before we start...:

  • I checked the documentation and didn't find this feature
  • I checked to make sure that this feature has not already been requested

Branch/Commit:

Main branch.

Describe the feature:

As a User
When I run skunk on a directory that has nested /spec or /test folders
Then I don't see reports for files inside nested /spec or /test folders

Problem:
Currenty, we are ignoring folders that starts with test or spec

a_module.pathname.to_s.start_with?("test", "spec")
but we are not ignoring folders that are nested like engines/my_engine/spec/.

This makes skunk to report those files as 0% test coverage and really high skunk scores.

I will abide by the code of conduct

@etagwerker
Copy link
Member

etagwerker commented Feb 13, 2021

@bronzdoc @bronzdoc Can this be closed? I assume that when @rdormer merged #65 it solved this bug? Thanks!

@arielj could you please confirm it is solved? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants