Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore folders that either start or end with spec or test, which will… #65

Merged
merged 3 commits into from
Jan 25, 2021

Conversation

rdormer
Copy link
Contributor

@rdormer rdormer commented Jan 21, 2021

… skip nested folders as well as top level

This addresses #60

@rdormer rdormer requested a review from a team as a code owner January 21, 2021 00:53
@rdormer rdormer requested review from bronzdoc and removed request for a team January 21, 2021 00:53
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #65 (d5c1863) into main (04738f1) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   93.85%   93.93%   +0.08%     
==========================================
  Files          23       23              
  Lines         423      429       +6     
==========================================
+ Hits          397      403       +6     
  Misses         26       26              
Impacted Files Coverage Δ
lib/skunk/cli/commands/status_reporter.rb 97.50% <100.00%> (+0.06%) ⬆️
...est/lib/skunk/cli/commands/status_reporter_test.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04738f1...d5c1863. Read the comment docs.

@bronzdoc bronzdoc force-pushed the fixes/nested-test-folders branch from 9e7f44c to 0637bdf Compare January 22, 2021 02:20
@bronzdoc bronzdoc force-pushed the fixes/nested-test-folders branch from 0637bdf to ca5eede Compare January 22, 2021 02:23
@bronzdoc bronzdoc requested a review from etagwerker January 22, 2021 02:24
Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdormer Looks good, please make sure to add a note to the CHANGELOG: https://github.com/fastruby/skunk/blob/main/CHANGELOG.md

@rdormer rdormer merged commit d456a76 into main Jan 25, 2021
@etagwerker etagwerker deleted the fixes/nested-test-folders branch January 27, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants