-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Travis and Azure for GitHub Actions #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @santisoler thanks for doing this 🙂 I left a few comments. Feel free to merge once those are dealt with.
Before merging, we need to have the PyPI and Test PyPI tokens in the repository secrets.
I just added those. I also sent you an invitation for the Test PyPI accounts of all our packages. |
MacOS seems to be using Python 2.7 pip. This is safer
@santisoler I tried using the Actions python with pip instead of conda and this cut down the test times from 3-4 minutes to ~1 min. It's really not necessary to use conda for Boule and many of our other packages that don't need complex dependencies. Rockhound might be the exception since now even numba can be pip installed. This might be a more significant speed up for CI than almost anything else we do. |
Thanks @leouieda for the review and all the changes. I agree with the decision of install everything with
I don't know what you meant on this sentence. Did you mean Harmonica? |
I mean that RockHound might require netCDF if we want to run any tests. But if not, then it should be fine. I think harmonica would be fine as well. |
Co-authored-by: Santiago Soler <santiago.r.soler@gmail.com>
Oh, now I get it! Sure, we can try it out on Harmonica and see if it works. I think this is looking great. Please merge if no more changes should be made. |
Fingers crossed that the deploy works 🤞🏽 |
Thanks for merging! Seems that deploys worked as charmed. Though one of the Mac OS tests was cancelled for no reason. Just rerun all jobs. |
Add GitHub Actions workflows for checking style, testing and deploying
Boule, based on the workflows of Harmonica. Remove TravisCI and Azure
configuration files. Split make check target in two:
make black-check
andmake flake8
. Ditch Travis and Azure badges onREADME.rst
. Add new GitHubActions badge. Tests are run on every matrix configuration: all OSs and all
Python versions. Use pip to install dependencies instead of setting up miniconda.
Related to fatiando/maintenance#1