Fix bug on safe_log
and solves discontinuous magnetic fields
#100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix how$|x| \gg |y|$ and/or $|x| \gg |z|$ ). Update calls to
_safe_log
checks ifr == |x|
. Add the other two shifted coordinates (y
andz
) as arguments for_safe_log
so we can use them to assess that the observation point is inline with a pair of vertices or not. Make the check by evaluating ify == 0 and z == 0
instead of-x == r
(withx < 0
), since-x
andr
could be the same value (up to machine precision) whiley
andz
are non-zero (specially when_safe_log
, update its docstrings, and update docstrings of kernels that mentioned the safe log function. Add tests that catches the bug, and that pass with the bugfix.Relevant issues/PRs:
Fixes #98